-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use --universal
flag with uv pip compile
#3032
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3032 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 120 120
Lines 17830 17830
Branches 3204 3204
=======================================
Hits 17765 17765
Misses 46 46
Partials 19 19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good, I can't speak of whether they're accurate/missing things, but definitely something nice. I'm fine merging this despite there not being many docs about it, but once this is documented more we can probably close the issue RE: replacing pip-compile
.
charset-normalizer==3.3.2 | ||
# via requests | ||
click==8.1.7 | ||
# via towncrier | ||
colorama==0.4.6 ; platform_system == 'Windows' or sys_platform == 'win32' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is stable enough to use as is. I ran uv pip compile --universal --no-strip-markers --python-version=3.8 --upgrade test-requirements.in -o test-requirements.txt
twice locally and it started duplicating requirements in the requirements file.
Ok so while investigating that I figured out that I can't fix it (the fix would require too much change in However! 1) the reason we have different results is because this wasn't a problem prior to 0.2.19, and 2) a workaround (because we want to stay current) is to just put Sphinx at the top of the requirements file. Though I haven't double checked for 2. |
While looking through the documentation, I came across https://github.com/astral-sh/uv-pre-commit, might be interesting to try out using that. |
I think we want to bump dependencies in pull requests separate from other PRs, so adding a pre-commit check that plays around with requirements sounds like a bad idea to me. |
Apparently `--universal` implies `--no-strip-markers`
I think there is a case of test flakiness again, the merge run failed on pypy-3.10 with a dtls issue again:
I think something similar to this happened recently elsewhere as well, might need to make an issue collecting test flakiness for pypy-3.10 |
Maybe we just have to bump GC counts yet again. (assuming that calls |
Follow up to #2958
Originally posted by @A5rocks in #2958 (review)
This pull request is adding the new
--universal
flag for the uv pip compile runs.