Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that --universal implies --no-strip-markers #5121

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

konstin
Copy link
Member

@konstin konstin commented Jul 16, 2024

Prompted by python-trio/trio#3032 (comment).

Should this go in the summary description or the extended description?

@konstin konstin requested a review from zanieb July 16, 2024 19:11
@zanieb
Copy link
Member

zanieb commented Jul 16, 2024

I'd probably include it in the long help not the summary.

@charliermarsh
Copy link
Member

Is this necessary? It writes markers so isn't it sort of implied by the output?

@konstin
Copy link
Member Author

konstin commented Jul 16, 2024

Not sure! Maybe we need something else to make the distinctness of --universal clear

@charliermarsh charliermarsh added the documentation Improvements or additions to documentation label Jul 17, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) July 17, 2024 15:46
@charliermarsh charliermarsh merged commit 3e93255 into main Jul 17, 2024
51 checks passed
@charliermarsh charliermarsh deleted the konsti/implies-no-strip-markers branch July 17, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants