Fix bugs where VCS dev-dependencies are poetry install/show even in --no-dev

poetry/packages/package.py

@@ -298,6 +298,7 @@ def add_dependency(
                     tag=constraint.get("tag", None),
                     rev=constraint.get("rev", None),
                     optional=optional,
+                    category=category,
                 )
             elif "file" in constraint:
                 file_path = Path(constraint["file"])

poetry/packages/vcs_dependency.py

@@ -7,7 +7,15 @@ class VCSDependency(Dependency):
     """
 
     def __init__(
-        self, name, vcs, source, branch=None, tag=None, rev=None, optional=False
+        self,
+        name,
+        vcs,
+        source,
+        branch=None,
+        tag=None,
+        rev=None,
+        optional=False,
+        **kwargs
     ):
         self._vcs = vcs
         self._source = source
@@ -21,7 +29,7 @@ def __init__(
         self._rev = rev
 
         super(VCSDependency, self).__init__(
-            name, "*", optional=optional, allows_prereleases=True
+            name, "*", optional=optional, allows_prereleases=True, **kwargs
         )
 
     @property

tests/puzzle/test_solver.py

@@ -986,6 +986,30 @@ def test_solver_can_resolve_git_dependencies_with_ref(solver, repo, package, ref
     assert op.package.source_reference.startswith("9cf87a2")
 
 
+def test_solver_marks_git_dev_dependencies_as_dev(solver, repo, package):
+    pendulum = get_package("pendulum", "2.0.3")
+    cleo = get_package("cleo", "1.0.0")
+    repo.add_package(pendulum)
+    repo.add_package(cleo)
+
+    package.add_dependency(
+        "demo", {"git": "https://github.com/demo/demo.git"}, category="dev"
+    )
+
+    ops = solver.solve()
+
+    check_solver_result(
+        ops,
+        [
+            {"job": "install", "package": pendulum},
+            {"job": "install", "package": get_package("demo", "0.1.2")},
+        ],
+    )
+
+    assert ops[0].package.category == "dev"
+    assert ops[1].package.category == "dev"
+
+
 def test_solver_does_not_trigger_conflict_for_python_constraint_if_python_requirement_is_compatible(
     solver, repo, package
 ):