Fix bugs where VCS dev-dependencies are poetry install/show even in --no-dev

[nyanpasu64]

Fixes #599.

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

• Added tests for changed code. (partially)
• Updated documentation for changed code. (i think this changes code to match intended/documented behavior)

I added a "test that solver marks git dev-dependencies as dev".

I did not add a test that "solver marks dev-dependencies with lists of version conditions as dev".

• I haven't used "lists of dependencies" in my own projects yet. (I just tried using Git dependencies today.)
• tests/puzzle/test_solver.py doesn't hit either of 2 breakpoints in poetry.py if isinstance(constraint, list):.
• tests/test_poetry.py test_poetry_with_multi_constraints_dependency() references directory tests/fixtures/project_with_multi_constraints_dependency and hits that above branch (but not the path with dev-dependencies). But it doesn't call solver.solve().

Where would that test go? Do I create a new directory fixture, or do I copy the general form of tests/puzzle/test_solver.py?

---

oops why are the tests failing? i swear it works on my machine... i think i've been living in a cozy and exclusively python 3.6 environment for too long

Do I edit VCSDependency.__init__() and put **kwargs after allows_prereleases=True? Force push?

[drunkwcodes]

LGTM with one place to change.

[drunkwcodes]

**kwargs should be the last one.

[nyanpasu64]

Force push, or append a commit to change this?

[drunkwcodes]

It's up to you and I'm wondering where would this thread goes after force push.

[nyanpasu64]

i'm pretty sure i force pushed, why is appveyor still failing?

[drunkwcodes]

i'm pretty sure i force pushed, why is appveyor still failing?

It's exciting.

[nyanpasu64]

I did not add a test that "solver marks dev-dependencies with lists of version conditions as dev".

is that not a problem?

[drunkwcodes]

@jimbo1qaz No. It is included with the proper name.

[nyanpasu64]

Do you mean there is already a test that ensures "dependency with list of constraints" behaves properly? And what is it called? I have not tested the behavior of my change, neither manually nor by adding a unit test.

[drunkwcodes]

@jimbo1qaz I mean your test is included in because of the 'test_' prefix.

And it covers #599 properly.

[nyanpasu64]

I don't think my test (or any other test in test_solver.py) covers #599 (list of multiple version constraints), with or without dev enabled (but i could be wrong about how pendulum works). My added test covers the related Git-package issue. I need to sleep and can't discuss further.

[drunkwcodes]

@jimbo1qaz Good night.

[nyanpasu64]

Any updates?

[jeamland]

I just ran into something that would be fixed by this (and got as far as writing my own fix). Any chance this will be merged soon?

[tsiq-rob]

I observe that this bug still exists, precluding dev dependencies sourced from git, which is a major pain. @sdispater Any chance of merging the fix?

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[nyanpasu64]

"lists of dev-dependencies" was fixed in develop by bb98480. In fact, #1005 was the exact same one-line change as I made, yet got merged quickly.

The changes I made to fix "VCS dependencies" are not in develop.

I rebased this branch on develop. I'm not working on Python projects at the moment, so I didn't test my rebase locally. I'm going to force-push and see if the tests pass.

[AndrewPix]

Why this fix still can not be approved? We are facing this problem too

[AndrewPix]

@drunkwcodes @sdispater Could you review and merge this PR ?

[nyanpasu64]

I have a project I created in older poetry. After removing a single package under Poetry version 1.0.0, this bug popped up again. Unfortunately the patch again doesn't apply cleanly. I don't know when I'll rebase it again.

I think I'll workaround it by removing my git dependency.

EDIT: Actually the bug appears to be fixed in Poetry 1.0.2?

[nyanpasu64]

Already fixed in #1725.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.