-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for setup.py as an export format #762
Conversation
Any reason this one has not had any movement on it? would be useful to me right now. |
@stefansedich i do think that the functionality still has value, but I am no longer sure if this is the right approach for this. I would like to attempt rewriting it so that it is a format for the export command. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
If this is going to sit for a while, could we at least get it as a "preview" version for those of us who need it (PyCharm users and/or those not willing to deal with dephell equivalent)? |
@jwiede thanks for bumping this I'll see if i can get this cleaned up and ready for review again. Not sure where the project team sits on this one though. |
+1 on something like this being useful! |
Would be incredibly useful to me as well, +1 |
Why? 😄 |
So it's a bit of a long story but here goes. We were using poetry for our packages and apps, but because poetry install takes > 20mins to update deps now we want to use poetry only for modules, and use pipenv to manage apps (see #2094 (comment) - we don't publish apps as modules an pipenv installs from lock much faster it saves debugging time). As our local debugging flow builds app in docker, this install time from lock really matters to us as well. However, ran into another problem yesterday that pipenv doesn't support adding editable deps that don't have setup.py so breaks our cludge temporary fix. Ultimately the pipenv thing was intended as a temporary measure that would save some time, hoping that performance of poetry would improve in future. We really like poetry and it is awesome everywhere else, it's just that in some projects with lots of deps it is making our dev flow very slow. |
Awesome, waiting with great anticipation for next release! Do you think #2149 will make it in as well @sdispater ? |
this looks useful to me to enter editable mode. Why closing it ? |
@teto you can create a setup shim with the following content for that. import setuptools; setuptools.setup() Additionally, poetry is in the process of removing the internal supprot for generating |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This change introduces
setup.py
as a valid export format.Resolves: #761