Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setup.py as an export format #762

Closed
wants to merge 1 commit into from

Conversation

abn
Copy link
Member

@abn abn commented Dec 25, 2018

This change introduces setup.py as a valid export format.

Resolves: #761

  • Added tests for changed code.
  • Updated documentation for changed code.

@stefansedich
Copy link

Any reason this one has not had any movement on it? would be useful to me right now.

@abn
Copy link
Member Author

abn commented Jul 3, 2019

@stefansedich i do think that the functionality still has value, but I am no longer sure if this is the right approach for this. I would like to attempt rewriting it so that it is a format for the export command.

@brycedrennan brycedrennan added the kind/feature Feature requests/implementations label Aug 17, 2019
@abn abn changed the title Add setuptools command to generate setup.py Add support for setup.py as an export format Aug 18, 2019
@stale
Copy link

stale bot commented Nov 13, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 13, 2019
@sdispater sdispater added stale and removed wontfix labels Nov 14, 2019
@stale stale bot removed the stale label Nov 14, 2019
@jwiede
Copy link

jwiede commented Feb 7, 2020

If this is going to sit for a while, could we at least get it as a "preview" version for those of us who need it (PyCharm users and/or those not willing to deal with dephell equivalent)?

@abn
Copy link
Member Author

abn commented Feb 10, 2020

@jwiede thanks for bumping this I'll see if i can get this cleaned up and ready for review again. Not sure where the project team sits on this one though.

@vegarsti
Copy link

vegarsti commented Jun 4, 2020

+1 on something like this being useful!

@jacques-
Copy link

jacques- commented Jul 7, 2020

Would be incredibly useful to me as well, +1

@finswimmer
Copy link
Member

Would be incredibly useful to me as well, +1

Why? 😄

@jacques-
Copy link

jacques- commented Jul 8, 2020

So it's a bit of a long story but here goes. We were using poetry for our packages and apps, but because poetry install takes > 20mins to update deps now we want to use poetry only for modules, and use pipenv to manage apps (see #2094 (comment) - we don't publish apps as modules an pipenv installs from lock much faster it saves debugging time). As our local debugging flow builds app in docker, this install time from lock really matters to us as well. However, ran into another problem yesterday that pipenv doesn't support adding editable deps that don't have setup.py so breaks our cludge temporary fix.

Ultimately the pipenv thing was intended as a temporary measure that would save some time, hoping that performance of poetry would improve in future. We really like poetry and it is awesome everywhere else, it's just that in some projects with lots of deps it is making our dev flow very slow.

@sdispater
Copy link
Member

@jacques- Regarding the speed of installation, you might want to take a look at #2595 which improves performances significantly and will be available in the next feature release.

@jacques-
Copy link

jacques- commented Jul 8, 2020

Awesome, waiting with great anticipation for next release!

Do you think #2149 will make it in as well @sdispater ?

@abn abn marked this pull request as draft July 27, 2020 01:27
@abn abn changed the base branch from develop to master July 27, 2020 01:28
@abn abn closed this Oct 6, 2020
@abn abn deleted the issue-761 branch October 6, 2020 21:52
@teto
Copy link

teto commented Feb 18, 2021

this looks useful to me to enter editable mode. Why closing it ?

@abn
Copy link
Member Author

abn commented Mar 20, 2021

@teto you can create a setup shim with the following content for that.

import setuptools; setuptools.setup()

Additionally, poetry is in the process of removing the internal supprot for generating setup.py files. If such an export is desirable, it can be implemented by the community via the upcoming pluggin system as a plugin to the export command.

@abn abn mentioned this pull request Mar 20, 2021
2 tasks
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support generation of poetry manged setup.py file
9 participants