Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export setup py #3736

Closed

Conversation

JasonAtallah
Copy link

@JasonAtallah JasonAtallah commented Feb 26, 2021

Pull Request Check List

Resolves: #761

  • Added tests for changed code.
  • Updated documentation for changed code.

@finswimmer finswimmer added the kind/feature Feature requests/implementations label Feb 27, 2021
@finswimmer finswimmer requested a review from a team February 27, 2021 07:46
@abn
Copy link
Member

abn commented Mar 20, 2021

Thank you for your contribution @JasonAtallah. Unfortunately, this is not a feature that will be supported in poetry. The linked pull request should provide more context. I will update #761 as well.

Duplicate-of: #762.

@abn abn closed this Mar 20, 2021
@JasonAtallah
Copy link
Author

Thank you for your contribution @JasonAtallah. Unfortunately, this is not a feature that will be supported in poetry. The linked pull request should provide more context. I will update #761 as well.

Duplicate-of: #762.

@abn Why will this not be supported? There is no new functionality, it's just reusing existing methods. I know personally this would be a great addition as not everyone in my organization uses Poetry.

@abn
Copy link
Member

abn commented Mar 21, 2021

I can understand the need in your scenario, however since the existing code is being dropped in a future release (as indicated in my last comment on #761), it does not make sense to keep it just to support this use case. Additionally, the generated setup file is not necessarily complete anymore as Poetry's supported features have outgrown it.

If the community has an interest in this feature, it could be implemented as an export format plug-in. See #3733 for progress on that front.

@abn abn mentioned this pull request Apr 19, 2021
2 tasks
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support generation of poetry manged setup.py file
3 participants