Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add paragraph about @ operator #5822

Merged
merged 6 commits into from
Jun 19, 2022

Conversation

Secrus
Copy link
Member

@Secrus Secrus commented Jun 9, 2022

Resolves: #5136
Resolves: #3142

Added documentation on @ operator in dependency specification.

@Secrus Secrus added the area/docs Documentation issues/improvements label Jun 9, 2022
@github-actions
Copy link

github-actions bot commented Jun 9, 2022

Deploy preview for website ready!

✅ Preview
https://website-qxcwwx9b8-python-poetry.vercel.app

Built with commit bf387a3.
This pull request is being automatically deployed with vercel-action

@Secrus Secrus requested a review from a team June 10, 2022 09:07
@Secrus
Copy link
Member Author

Secrus commented Jun 15, 2022

@clintonroy I have addressed your comments.

@Secrus Secrus requested review from clintonroy and a team June 15, 2022 19:40
@neersighted
Copy link
Member

I'm wondering if this is really the correct place to add the docs -- since there's no surrounding mention of poetry add it feels out of place. If this really is the best place then the opening sentence/section title should probably be something along the lines of "adding packages with constraints using the CLI" -- if there's a more natural location with other CLI docs, we should just add a link to that section.

@Secrus
Copy link
Member Author

Secrus commented Jun 19, 2022

@neersighted I added link in add command docs and changed first paragraph of the @ documentation.

docs/dependency-specification.md Outdated Show resolved Hide resolved
docs/dependency-specification.md Outdated Show resolved Hide resolved
docs/cli.md Outdated Show resolved Hide resolved
docs/dependency-specification.md Outdated Show resolved Hide resolved
docs/dependency-specification.md Outdated Show resolved Hide resolved
docs/dependency-specification.md Outdated Show resolved Hide resolved
docs/dependency-specification.md Outdated Show resolved Hide resolved
Co-authored-by:  Bjorn Neergaard <[email protected]>

Co-authored-by: Bjorn Neergaard <[email protected]>
@Secrus Secrus requested a review from neersighted June 19, 2022 21:08
@neersighted neersighted merged commit a3aafa8 into python-poetry:master Jun 19, 2022
@Secrus Secrus deleted the remove-at-from-docs branch June 21, 2022 13:25
@mkniewallner mkniewallner mentioned this pull request Jul 12, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Documentation issues/improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What does the @ in poetry add pendulum@^2.0.5 in a docs example mean? Operator at not documented
3 participants