Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git custom tls #5764

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

maayanbar13
Copy link
Contributor

@maayanbar13 maayanbar13 commented Jun 3, 2022

Pull Request Check List

Resolves: #5568

  • Updated documentation for changed code.
  • Added tests for changed code.

This allows certificates config option to also be applied to Dulwich requests.

@finswimmer
Copy link
Member

Hello @maayanbar13,

any chance that you can go on with your work on this PR?

Thanks a lot for your contribution!

fin swimmer


if not certs.verify:
config.set("http", "sslVerify", False) # type: ignore[no-untyped-call]

client, path = get_transport_and_path(url, **kwargs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't appear to actually pass in config anywhere?

@jelmer
Copy link
Contributor

jelmer commented Sep 4, 2022

The underlying code here has now changed, and there's already a config object being created and passed into get_transport_and_path. Modifying the existing config object is probably not what you want, since that'll change the configuration on disk.

One of the things you could do is add the ConfigDict with extra settings you've created to the front of that config stack. I.e.:

your_config_dict = ConfigDict9)
your_config_dict.set(...)
config.backends.insert(0, your_config_dict)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom certs and tls auth for private git repositories
3 participants