-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git custom tls #5764
base: main
Are you sure you want to change the base?
Git custom tls #5764
Conversation
Hello @maayanbar13, any chance that you can go on with your work on this PR? Thanks a lot for your contribution! fin swimmer |
|
||
if not certs.verify: | ||
config.set("http", "sslVerify", False) # type: ignore[no-untyped-call] | ||
|
||
client, path = get_transport_and_path(url, **kwargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't appear to actually pass in config anywhere?
The underlying code here has now changed, and there's already a config object being created and passed into get_transport_and_path. Modifying the existing config object is probably not what you want, since that'll change the configuration on disk. One of the things you could do is add the ConfigDict with extra settings you've created to the front of that config stack. I.e.:
|
Pull Request Check List
Resolves: #5568
This allows
certificates
config option to also be applied toDulwich
requests.