Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom certs and tls auth for private git repositories #5568

Open
abn opened this issue May 8, 2022 · 1 comment · May be fixed by #5764
Open

Support custom certs and tls auth for private git repositories #5568

abn opened this issue May 8, 2022 · 1 comment · May be fixed by #5764
Labels
kind/feature Feature requests/implementations

Comments

@abn
Copy link
Member

abn commented May 8, 2022

Similar to how user credentials are handled in #5567 we require git clones to support TLS certificates as available with HTTP repositories.This should also handle in the (presenty in development) verify = false option for repositories.

For this, the get_transport_and_path call will need to pass in the correct vars or use a custom urrlib pool.

credentials = get_default_authenticator().get_credentials_for_url(url=url)
client, path = get_transport_and_path(
url, username=credentials.username, password=credentials.password
)

This will also have to be done only for http vcs urls.

Prior to #5428, users could rely on system git client to handle these via options like

git config http.sslverify false

This is no longer possible unless a user forces the system git client backend to be used.

poetry config experimental.system-git-client true
@abn abn added kind/feature Feature requests/implementations Good First Issue labels May 8, 2022
@maayanbar13
Copy link
Contributor

As it seems I'm already on a roll with disabling TLS verification I'll work on this as well :)

@maayanbar13 maayanbar13 linked a pull request Jun 3, 2022 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Feature requests/implementations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants