Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc. improvements to group filtering logic and related options #5338

Merged
merged 12 commits into from
Mar 24, 2022
Merged

misc. improvements to group filtering logic and related options #5338

merged 12 commits into from
Mar 24, 2022

Commits on Mar 24, 2022

  1. cmd/install: mark --remove-untracked as deprecated

    @abn
    abn committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    a5c1479 View commit details
    Browse the repository at this point in the history

  2. cmd/install: enable root when --only is used

    @abn
    abn committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    4b0066f View commit details
    Browse the repository at this point in the history

  3. refactor group command logic and simplify installer 

    This change removed code duplication for group option handling in
commands and group activation in installer. The installer now only
allows for `only_groups` and removes `with_groups`/`without_groups`.

Additionally, this change enables code reuse for group flags in the
update command and centralises deprecated option handling logic for
these options.

Further, this fixes regression when using `update --no-dev`.
    @abn
    abn committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    d272663 View commit details
    Browse the repository at this point in the history

  4. groups: deprecate --default flag

    @abn
    abn committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    01774e1 View commit details
    Browse the repository at this point in the history

  5. groups: warn when with/without is used with only 

    This change adds a warning that values of `with`/`without` options are
ignored when used with `only`.
    @abn
    abn committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    f338da9 View commit details
    Browse the repository at this point in the history

  6. tests: improve install command group opt coverage

    @abn
    abn committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    77f1d95 View commit details
    Browse the repository at this point in the history

  7. tests: fix and improve installer test coverage 

    This change improves test scenarios for installer with dependency
groups. Previously, the usage of populated installed repositories
could lead to tests incorrectly passing as no operations were
performed. These cases now forces syncronisation and uses a clean
installed repository instance instead.
    @abn
    abn committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    36c0032 View commit details
    Browse the repository at this point in the history

  8. doc: improve dependency group related documentation

    @abn
    abn committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    c71cdfc View commit details
    Browse the repository at this point in the history

  9. tests: add coverage for --no-root when using groups

    @abn
    abn committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    442ff8e View commit details
    Browse the repository at this point in the history

  10. tests: improve coverage for install group options 

    Co-authored-by: Randy Döring <[email protected]>
    @abn @radoering
    abn and radoering committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    1a053c9 View commit details
    Browse the repository at this point in the history

  11. doc: add warning for --with and --without usage

    @abn
    abn committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    16cc701 View commit details
    Browse the repository at this point in the history

  12. test: improve coverage for show with group options

    @abn
    abn committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    f6bcfb9 View commit details
    Browse the repository at this point in the history