misc. improvements to group filtering logic and related options #5338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
radoering
requested changes
Mar 22, 2022
abn
force-pushed
the
improve-group-filtering
branch
from
4f908cb
to
9a3057f
Compare
abn
force-pushed
the
improve-group-filtering
branch
from
9a3057f
to
65ea871
Compare
radoering
requested changes
Mar 23, 2022
radoering
requested changes
Mar 23, 2022
3 tasks
abn
force-pushed
the
improve-group-filtering
branch
from
03be879
to
83206ca
Compare
finswimmer
requested changes
Mar 24, 2022
This change removed code duplication for group option handling in commands and group activation in installer. The installer now only allows for `only_groups` and removes `with_groups`/`without_groups`. Additionally, this change enables code reuse for group flags in the update command and centralises deprecated option handling logic for these options. Further, this fixes regression when using `update --no-dev`.
This change adds a warning that values of `with`/`without` options are ignored when used with `only`.
This change improves test scenarios for installer with dependency groups. Previously, the usage of populated installed repositories could lead to tests incorrectly passing as no operations were performed. These cases now forces syncronisation and uses a clean installed repository instance instead.
Co-authored-by: Randy Döring <[email protected]>
abn
force-pushed
the
improve-group-filtering
branch
from
83206ca
to
f6bcfb9
Compare
radoering
approved these changes
Mar 24, 2022
finswimmer
approved these changes
Mar 24, 2022
2 tasks
Merged
Closed
3 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install --onlylogic to no longer implicitly disable root package installation. (added test coverage)withoutandwithgroup specifications, replacing withonlygroup logic.installcommand with group filtering options.defaultgroup anddefault dependencies.--helpoutput and warning around combining--onlywith--with | --without.--defaultoption to reduce CLI cognitive load on users.install --remove-untrackedas deprecated--no-dev=>--only default,--only-dev=>--without defaultetc.Closes: #4361
Resolves: #4577
Discussion: https://github.com/orgs/python-poetry/teams/core/discussions/8
PS: Commits are separated by functional changes.