Prefer authenticator from repository when available #4488
Conversation
Signed-off-by: Andreas Stenius <[email protected]>
| @@ -444,6 +443,3 @@ def _get(self, endpoint: str) -> Optional[Page]: | |||
| ) | |||
|
|
|||
| return Page(response.url, response.content, response.headers) | |||
|
|
|||
| def _download(self, url, dest): # type: (str, str) -> None | |||
| return download_file(url, dest, session=self.session) | |||
There was a problem hiding this comment.
Removed this, as it is an exact copy of the one from the base class, PypiRepository.
|
I can't fathom that of all the issues that has been reported with custom pypi registries and SSL issues, that no one picked up that the new installer can be turned off: From what I understand, this gives you the same installer that is used in 1.0.10, that several users reports works as it should. Even downgrading to as a work-around for the issues. |
|
Ping. Any feedback on this? |
@kaos, well, I'm one that recommended either downgrading or setting |
|
@absassi |
|
Closed and re-opened to re-trigger checks being run. |
|
This should have been made obsolete by #5518 -- please test on master and comment/re-open if you think some of these changes are still valid. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Signed-off-by: Andreas Stenius [email protected]
Resolves: #1012 #2593 #3110 #4016
Supersedes: #3349
Introduced: #2595
Feature toggle to side step this issue until resolved:
This will ensure that the configured certificates and auth are used when downloading files from a legacy repository.
There are quite a few issues relating to this being broken, so the list of resolves above may be incomplete.