support specifying algorithm when calculating file dependency hash.

[kaos]

Signed-off-by: Andreas Stenius [email protected]

Pre-work for: python-poetry/poetry#4085

• Added tests for changed code.

Currently, poetry assumes all archive file hashes are using sha256. This opens for the ability to support other algorithms. (I have a real use case, where the archive uses md5, for instance.)

[kaos]

Ping. Any feedback on this?

[wcn00]

I am currently blocked because all the packages in my gemfury repo are md5 signed so we cannot upgrade/install anything using them. Is there any circumvention I can use while we wait for this pr to land? This is a significant blocker for my company.

[kaos]

@wcn00 Yes, the feature toggle I discovered, and present in python-poetry/poetry#4488 should allow you to use the old mechanism for installing dependencies, bypassing this entirely:

poetry config experimental.new-installer false

I think it was a mistake to enable this new installer by default, would have been better as an opt-in.

[wcn00]

Thankyou @kaos You're a gentleperson and a scholar :) Disabling that feature gets me out of this bind which was threatening to ruin my week!
Thanks again

[kaos]

Ping. @finswimmer @abn
I've got no reaction at all from any maintainers in the past two weeks on any of my 3 PRs. If you are really busy, a quick comment as such, would be appreciated, acknowledging that you've seen this.

Thank you.

[kaos]

Bump.

I can address conflicts etc, if there is any sign this PR will be getting any review activity.
As I've found a work-around for the issues I had (with simply using the old resolver) I will not fret over these fixes..

[FlorianLudwig]

@kaos Patience. I also once wanted wrote a patch for the same feature. I would estimate you have to wait another year to get it merged. (ref: python-poetry/poetry#2422 for ETA for changes like this)

Writing "bump" here just gives notifications to those interested in the feature (like me) but doesn't make things faster

[neersighted]

This change is very small and well-tested. While overall I'm not enthusiastic about md5 support, I think we need to take the pragmatic approach here.

[kaos]

This was fixed in 68bf052

[neersighted]

Yep -- you're right. I'll take a look at the poetry changes next.