Strip local version labels from Packages from PackageInfo #4219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that we create closer to reality scenarios when testing init command. Relates-to: #3073
This change ensures that we resolve dependencies to correctly propagate markers when using `lock --no-update`. Resolves: #3048
This change ensures that package inspection will handle rich core metadata available for poetry managed projects. This will allow, nested local path dependencies to use "develop" mode packages. Resolves: #3098
Relates-to: #3155
Resolves: #3069
This change, moves common functionality from exporter into the locker to allow for sharing of logic that can generate `DependencyPackage` instances given a a list of requirements using the lock data. (cherry picked from commit c2adb32)
When installing poetry < 1.2.0a1 add a warning indicating the breakage of `self update` command usage. Relates-to: #4040
Relates-to: #4040
replace f-string in get-poetry by `.format()` for python2 compatibility
Reorganize documentation
Fix documentation relative reference
Fix locked information for path, url and VCS dependencies
* handle poetry init non-interactive dependencies 1. in non-interactive mode, suppress "This command will guide you through..." 2. in interactive mode, respect command line --dependency if the user chooses NO for "Would you like to define your main dependencies interactively?"
|
Oh dang. I didn't see we still need to support Python 2.7 in integration tests. Can you nice folks let me know if you want me to update this (it's easy, just a type hint) or if we should drop the Python2.7 tests? |
|
@vedosis if the fix is for the next minor; you won't have to suport 2.7. Just rebase your chages against |
|
Rebased to master, closing this PR in favor of the next. |
|
SonarCloud Quality Gate failed.
|
2 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #2613
RE: Documentation... I can't see anywhere the documentation would need to be updated. If it does, point me at it and I'll work it over.