Fix locked information for path, url and VCS dependencies #4202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdispater
added
kind/bug
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Jun 23, 2021
3 tasks
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #3875 (#3947 for the
1.1branch), people were starting to see issues where packages would not be installed or would be removed.This was a bit tricky to track down but the cause was that the locked data for dependencies were not correct which caused packages to be discarded in the resolution process.
This issue has existed for quite some time but was not discovered until now because the fact that all packages were whitelisted meant that they were not retrieved from the lock file.
Note that users will need to update their lock file for the fix to take effect. It's also important to note that
lock --no-updatewill not work and a full relock will be needed.Pull Request Check List
Resolves: #4051
Resolves: #3956
Resolves: #4111