-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to the new version of Cleo #3618
Conversation
6fc3f80
to
3d45a4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. 👍
I recognize that you've started to use type hints instead of type comments. I've avoided this in my PRs regarding adding missing type hints, to make cherry-picking to the 1.1 easier. But I guess once this PR is merged, we should switch the type comments to type hints (with com2ann this seems to be quiet easy) for the sake of consistency.
I let it to you to merge this PR.
@finswimmer The And, yes, I plan on converting everything to type hints. |
This morning I noticed that "poetry env info -p" and "poetry env info --path" are failing with a stack trace; a bisect narrowed it down to this PR. I haven't had a chance to dig into it yet. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR changes the code base to migrate to the new, work in progress, version of Cleo which will help improve things in order to better implement some features planned for the 1.2 release.
The major changes are the following: