Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breaking change to 'poetry run' to changelog #6440

Closed
1 task done
brandon-leapyear opened this issue Sep 7, 2022 · 3 comments
Closed
1 task done

Add breaking change to 'poetry run' to changelog #6440

brandon-leapyear opened this issue Sep 7, 2022 · 3 comments
Labels
area/docs Documentation issues/improvements

Comments

@brandon-leapyear
Copy link

  • I have searched the issues of this repo and believe that this is not a duplicate.

Issue

The changelog currently mentions a bug fix around poetry run:

Fixed an error where command line options were not taken into account when using the run command. (#3618)

(link)

But this is actually a breaking change. On Poetry 1.1, the following:

poetry run foo -- arg1 arg2

would run foo -- arg1 arg2 in the poetry environment, but on Poetry 1.2, the -- is handled by poetry and stripped. This causes issues with tox, because tox -- arg1 arg2 is very different from tox arg1 arg2. With Poetry 1.2, the following is now required (as opposed to before, when it was optional): poetry run -- foo -- arg1 arg2. It's currently very difficult to search for this change in behavior in the CHANGELOG (I had to search for any instances of run in the CHANGELOG, and it ended up being under the 1.2.0a section)

@brandon-leapyear brandon-leapyear added area/docs Documentation issues/improvements status/triage This issue needs to be triaged labels Sep 7, 2022
@catcombo
Copy link

We have the same problem running custom Django command that accepts another command with arguments.

@neersighted neersighted removed the status/triage This issue needs to be triaged label Sep 20, 2022
@neersighted
Copy link
Member

This is known -- I've just pushed an update to the release notes calling it out, and linking here.

Copy link

github-actions bot commented Mar 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Documentation issues/improvements
Projects
None yet
Development

No branches or pull requests

3 participants