Change README default format to Markdown and add it to pyproject.toml automatically #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just so you know I am currently developing a TOML library which should ease the programmatic creation/modification of the I'll let you know when it's ready (hopefully it should be this week). |
|
Awesome. Let me know if you want some help ;) |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Close in favor of #1515 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #280.
The problem right now is that I cannot change the
pyproject.toml's structure, which is created here: https://github.com/cauebs/poetry/blob/a8b534811c1e11541673eb426d34ef9b824321d4/poetry/layouts/layout.py#L84-L89I don't find the current solution very elegant. If I want to optionally add the readme to the default pyproject.toml, we'll end up with four different strings (with license and readme, just readme, just license or neither). I could edit the strings to insert a line in the correct position, but that's ugly as well. This TOML library is becoming very inconvenient. How should I deal with this?