Default README format to Markdown in "new" (#280) #1515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 29, 2019 20:56
**NEW** * A new parameter called `--readme` for `poetry new` is introduced, which used for defining the README format. This can be set either to `md` or `rst` * The readme is included in the `pyproject.toml` **CHANGE** * The default README format is now `.md` **FIX** * Test for `poetry new` is added
kasteph
previously approved these changes
Nov 3, 2019
There was a problem hiding this comment.
Thanks for your contribution @finswimmer! 🍡 💫
The PR looks good to me with two small comments but these aren't blockers necessarily for merging. @sdispater what do you think of having Markdown as the default readme format?
|
The isort check is new, isn't it? This would change > 100 files. Should I really do this? |
2 tasks
|
Any updates? |
finswimmer
force-pushed
the
issue-280-readme-md-default
branch
from
8a70d79
to
6fa062c
Compare
finswimmer
force-pushed
the
issue-280-readme-md-default
branch
from
809d397
to
2be6781
Compare
abn
added a commit
to abn/poetry
that referenced
this pull request
Aug 6, 2020
This change makes readme formant configurable, defaulting to markdown when using the new command. Resolves: python-poetry#280 Closes: python-poetry#1515 Co-authored-by: Arun Babu Neelicattu <[email protected]>
kasteph
approved these changes
Aug 24, 2020
abn
added a commit
to abn/poetry
that referenced
this pull request
Aug 27, 2020
This change makes readme formant configurable, defaulting to markdown when using the new command. Resolves: python-poetry#280 Closes: python-poetry#1515 Co-authored-by: Arun Babu Neelicattu <[email protected]>
|
Closing this in favour of #2768. @finswimmer @stephsamson can we get that one approved? This change is included there. |
abn
added a commit
to abn/poetry
that referenced
this pull request
Sep 1, 2020
This change makes readme formant configurable, defaulting to markdown when using the new command. Resolves: python-poetry#280 Closes: python-poetry#1515 Co-authored-by: Arun Babu Neelicattu <[email protected]>
abn
added a commit
to abn/poetry
that referenced
this pull request
Sep 22, 2020
This change makes readme formant configurable, defaulting to markdown when using the new command. Resolves: python-poetry#280 Closes: python-poetry#1515 Co-authored-by: Arun Babu Neelicattu <[email protected]>
Hi! First many thanks for that tool! From above, will README.md with In fact I'd like to be able to control getting a Markdown Thank you, |
abn
added a commit
to abn/poetry
that referenced
this pull request
Apr 9, 2021
This change makes readme formant configurable, defaulting to markdown when using the new command. Resolves: python-poetry#280 Closes: python-poetry#1515 Co-authored-by: Arun Babu Neelicattu <[email protected]>
abn
added a commit
to abn/poetry
that referenced
this pull request
Apr 10, 2021
This change makes readme formant configurable, defaulting to markdown when using the new command. Resolves: python-poetry#280 Closes: python-poetry#1515 Co-authored-by: Arun Babu Neelicattu <[email protected]>
abn
added a commit
that referenced
this pull request
Apr 12, 2021
This change makes readme formant configurable, defaulting to markdown when using the new command. Resolves: #280 Closes: #1515 Co-authored-by: Arun Babu Neelicattu <[email protected]>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #280.
NEW
--readmeforpoetry newis introduced, which used for defining the README format. This can be set either tomdorrstpyproject.tomlCHANGE
.mdFIX
poetry newis addedPull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
Note: If your Pull Request introduces a new feature or changes the current behavior, it should be based
on the
developbranch. If it's a bug fix or only a documentation update, it should be based on themasterbranch.If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!