Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdist: find packages incorrectly including non-package directories during setup.py generation #2283

Closed
abn opened this issue Apr 8, 2020 · 2 comments · Fixed by python-poetry/poetry-core#17
Closed

sdist: find packages incorrectly including non-package directories during setup.py generation #2283

abn opened this issue Apr 8, 2020 · 2 comments · Fixed by python-poetry/poetry-core#17
Labels
kind/bug Something isn't working as expected

Comments

@abn
Copy link
Member

abn commented Apr 8, 2020

The issue occurs when attempting poetry install on https://github.com/python-poetry/core/tree/1172536cac35ca4e2519b9bd516ae8f1cf23994a. This only occurs when using poetry at 1.1.0a1 or current devel branch. 1.0.5 works without issue.

The broken path is triggered due to the inclusion of tests as a package source.

packages = [
    {include = "poetry"},
    {include = "tests", format = "sdist"},
]

Log and generated setup.py file is available at https://gist.github.com/abn/669c95565b957f6267cda71c2078278e.

Issue seems to be related to how setup.py is populated with packages = It treats non-package directories as packages, hence causing pip editable install to fail.

Note that this might be a low priority issue if we decide to drop setup.py generation in the future.
@abn abn added the kind/bug Something isn't working as expected label Apr 8, 2020
@abn
Copy link
Member Author

abn commented Apr 8, 2020

1.0.5 contains the fix from #1626 this needs to be ported over to core.

abn pushed a commit to abn/poetry-core that referenced this issue Apr 8, 2020
@finswimmer @abn
fix subpackage check for setup.py generation
f8c3700 
Resolves: python-poetry/poetry#2283
@abn abn mentioned this issue Apr 8, 2020
Merged
abn pushed a commit to python-poetry/poetry-core that referenced this issue Apr 9, 2020
@finswimmer @abn
fix subpackage check for setup.py generation
948a496 
Resolves: python-poetry/poetry#2283
abn added a commit to abn/poetry-core that referenced this issue Apr 9, 2020
@abn
Remove tests from sdist
a3a83cd 
Adding tests causes ci issues with the current preview release of
poetry. For the interim, removing this until core release is
stabilised.

Related-to: python-poetry/poetry#2283
@abn abn mentioned this issue Apr 9, 2020
Merged
abn added a commit to python-poetry/poetry-core that referenced this issue Apr 12, 2020
@abn
Remove tests from sdist
f63d544 
Adding tests causes ci issues with the current preview release of
poetry. For the interim, removing this until core release is
stabilised.

Related-to: python-poetry/poetry#2283
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix subpackage check for setup.py generation abn/poetry-core
1 participant
@abn