Fix PEP-517 issues for projects using build scripts #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abn
force-pushed
the
issues/1516
branch
4 times, most recently
from
8aaee18
to
d10d3b4
Compare
abn
force-pushed
the
issues/1516
branch
2 times, most recently
from
b8acbaf
to
66c9ed4
Compare
A temporary setup file is required for various scenarios at the moment. This change introduces a context manager such that generates a temporary setup.py file and handles cleanup on exiting the context.
Adding tests causes ci issues with the current preview release of poetry. For the interim, removing this until core release is stabilised. Related-to: python-poetry/poetry#2283
kasteph
approved these changes
Apr 12, 2020
|
Did it release in any version? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to do this, we introduce a context manager in sdist builder. This can also be reused for the editable builder in the poetry code base.
Resolves: python-poetry/poetry#1516
Removed tests inclusion in sdist due to python-poetry/poetry#2283. This was breaking CI with preview poetry release.