Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: bump to version 1.1.0-rc.1 #443

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

finswimmer
Copy link
Member

@finswimmer finswimmer commented Aug 16, 2022

Changed

  • Replaced Poetry's helper method canonicalize_name() by packaging.utils.canonicalize_name() (#418).
  • Removed unused code (#419).

Fixed

  • Fixed an issue with markers, that results in incorrectly resolved extra dependencies (#415).
  • Fixed an issue where equal markers had not the same hash (#417).
  • Fixed allows_any() for local versions (#433).
  • Fixed special cases of next_major(), next_minor(), etc. and deprecated ambiguous usage (#434).
  • Fixed an issue with Python constraints from markers (#436).

Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My pedantic self is struggling with the reversed chronological order of the issues but think I can accept it. 😉

Just some minor improvements.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@dimbleby
Copy link
Contributor

Any interest in updating vendored code? Now seems as good a time as any. I'll make an MR and you can decide whether to take it before the release or not.

I guess I'll add what I feel is my usual plea: IMO just release 1.1.0 and forget all this a2, b3, rc1 stuff, there are plenty of numbers after zero for 1.1.1, 1.1.2, etc...

@finswimmer finswimmer force-pushed the release/1.1.0-rc.1 branch 2 times, most recently from af5b69d to 1f0307c Compare August 16, 2022 19:15
mkniewallner
mkniewallner previously approved these changes Aug 16, 2022
Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added another fix. Proposal for changelog entry:

Fixed special cases of next_major(), next_minor(), etc. and deprecated ambiguous usage (#434).

@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@finswimmer finswimmer marked this pull request as ready for review August 17, 2022 09:47
@finswimmer finswimmer merged commit a43b3b5 into python-poetry:main Aug 17, 2022
bostonrwalker pushed a commit to bostonrwalker/poetry-core that referenced this pull request Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants