Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent hash #417

Merged
merged 2 commits into from
Jul 31, 2022
Merged

Consistent hash #417

merged 2 commits into from
Jul 31, 2022

Conversation

dimbleby
Copy link
Contributor

The __eq__ and __hash__ implementations on the SingleMarker did not use the same things - one of them looked at the constraint and the other at the constraint_string. I've added a testcase demonstrating the difference.

Then I noticed that no-one actually uses the constraint_string anyway, so removed it. I've done that in a separate commit in case it's controversial...

@sonarcloud
Copy link

sonarcloud bot commented Jul 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@radoering radoering merged commit 7efc33e into python-poetry:main Jul 31, 2022
@dimbleby dimbleby deleted the consistent-hash branch July 31, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants