Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PEP-517 issues for projects using build scripts #12

Merged
merged 4 commits into from
Apr 12, 2020

Conversation

abn
Copy link
Member

@abn abn commented Mar 31, 2020

In order to do this, we introduce a context manager in sdist builder. This can also be reused for the editable builder in the poetry code base.

Resolves: python-poetry/poetry#1516

Removed tests inclusion in sdist due to python-poetry/poetry#2283. This was breaking CI with preview poetry release.

@abn abn force-pushed the issues/1516 branch 4 times, most recently from 8aaee18 to d10d3b4 Compare March 31, 2020 18:06
@abn abn requested a review from kasteph April 1, 2020 18:46
@abn abn self-assigned this Apr 1, 2020
@abn abn requested review from a team and removed request for kasteph April 1, 2020 19:12
@abn abn added the Bug Something isn't working label Apr 1, 2020
@abn abn force-pushed the issues/1516 branch 2 times, most recently from b8acbaf to 66c9ed4 Compare April 7, 2020 00:10
abn added 2 commits April 9, 2020 17:45
A temporary setup file is required for various scenarios
at the moment. This change introduces a context manager
such that generates a temporary setup.py file and handles
cleanup on exiting the context.
abn added 2 commits April 9, 2020 18:00
Adding tests causes ci issues with the current preview release of
poetry. For the interim, removing this until core release is
stabilised.

Related-to: python-poetry/poetry#2283
@abn abn merged commit 9c4cdc9 into python-poetry:master Apr 12, 2020
@abn abn deleted the issues/1516 branch April 12, 2020 09:27
@aviramha
Copy link

Did it release in any version?

@sdispater sdispater mentioned this pull request Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not build wheels for XXX which use PEP 517
3 participants