Bringing out release 0.3.4 #49

repagh · 2019-03-16T13:25:04Z

I have been looking a bit into getting a windows-also build in conda-forge. To do that cleanly, we need to bring out a new slycot release.

Would it be an option to simply tag v0.3.4, or do we need to merge/fix other issues first?

moorepants · 2019-03-16T15:46:31Z

@repagh I'm adding you a maintainer on the conda forge feedstock: conda-forge/slycot-feedstock#12

repagh · 2019-04-16T06:53:15Z

Thanks Jason.
@murrayrm , I propose returning the favour....

Any objections if we merge this? Next week my students are starting control classes, and having slycot in conda-forge would so much simplify the install instructions....

murrayrm · 2019-04-17T05:22:15Z

No problem on my end. Go for it!

repagh · 2019-04-17T09:43:48Z

I am a regular member, not maintainer. Turns out I cannot add @moorepants.
And apparently I cannot merge PR #53 either. No merge button. Is that because I have no write access to the Slycot repository, or because I cannot merge my own PR?

roryyorke · 2019-04-17T16:38:58Z

I've merged the 3 outstanding PRs.

I think conda-forge looks at PyPI for package sources, so we not only need a tag, but a PyPI upload.

I think @repagh should have commit rights---I don't actually know how to check whether or not he does, but from the log I don't see any merges or commits to master made by him, so I guess he doesn't. I also support giving @moorepants commit rights. I don't think I can make changes of this sort.

repagh · 2019-04-17T17:19:42Z

I have a pull request on the conda-forge feedstock for this. That one temporarily used the branch from my repository to get the source, but I intend to change that to use source from the python-control github repository, using a tagged release, rather than making a detour over PyPi; In that way it is immediately clear where the source is coming from.

repagh · 2019-04-17T17:27:27Z

This means that I still need a tag (v0.3.4) to complete the feedstock.

roryyorke · 2019-04-17T19:19:55Z

OK, great. The remaining hold-up is release notes, see e.g. https://github.com/python-control/Slycot/releases/tag/v0.3.3. I'll try to do that this weekend; will post draft notes here.

I assume we'll still eventually upload a source tarball to PyPI?

moorepants · 2019-04-17T21:10:29Z

I recommend releasing to PyPI and having conda forge pull from there. It helps to ensure people can actually install and build from the PyPi release being that the github tarball and the pypi tarballs are different.

moorepants · 2019-04-17T22:04:22Z

Also, the conda forge infrastructure checks pypi for updated packages and automatically create's PRs on the feedstock when pypi updates.

roryyorke · 2019-04-18T11:00:47Z

proposed release notes below. I'm not very familiar with the system pencil terminology, please let me know if what i've written is nonsense.

title: 0.3.4: added ag08bd, sb10jd, tg01ad, and tg01fd; switched to scikit-build.

New features

Support for four SLICOT routines was added by Marcus Liljedahl.

ag08bd Process system pencil to find multivariable zeros

ag08bd takes a system pencil (E,A,B,C,D) and returns a matrix pair (Af, Ef) which can be used to find the finite multivariable ("Smith") zeros. The orders of infinite zeros, right and left Kronecker indices, and multiplicities of infinite eigenvalues are also returned.

sb10jd Convert descriptor to non-descriptor form

sb10jd converts a descriptor state-space system (E,A,B,C,D) to a regular state-space system (Ad, Bd, Cd, Dd).

tg01ad Balance system pencil

tg01ad balances system pencils (E,A,B,C,D), with D=0, such that the rows and columns of the resulting pencil are as close in norm as possible.

tg01fd SVD-like coordinate form of system pencil

tg01fd finds the orthogonal transformation matrices for a system pencil (E,A,B,C,D), with D=0, such that the result is in SVD-like coordinate form.

Build

Rene van Paassen switched the build over to scikit-build, which allows for flang to be used to build SLICOT on Windows, and improves the build output for developers.

Testing

Python 3.7 was added to the Travis CI build set.

The tests no longer use the deprecated np.matrix type.

Added a regression test for #6, for td04ad.

Pull requests and issues associated with the release

PRs merged: #32, #34, #36, #38, #43, #45, #51, #52, #53, #56, #57
Issues fixed: #35, #37, #47, #55
Issues closed ("wont-fix"): #40, #41, #48

repagh · 2019-04-18T15:28:14Z

Looks good. Then again, I mostly use physical pencils....
The switch to scikit was a means to get additional flexibility in selecting build tools, the switch to flang is a result from that.

roryyorke · 2019-04-23T16:11:18Z

0.3.4 released

roryyorke · 2019-04-23T16:28:09Z

I'm afraid I didn't realize there was a bit more to releasing; it looks like setup.py must be edited. I've deleted v0.3.4 for now.

I assume the idea is to have a release branch.

murrayrm · 2019-04-23T17:13:19Z

If it helps, the workflow for a release for python-control is here: https://github.com/python-control/python-control/wiki/Release-instructions

repagh · 2019-04-24T07:25:11Z

What happened? I thought I had tweaked setup.py to take the version information from git. If that does not work -- e.g., because the source is tarballed --, it assumes the default hardcoded version (currently 0.3.3, so that must be updated).

roryyorke · 2019-04-24T07:34:09Z

From what I can tell, the tests fail because there's no `--long` in the git-describe command. Besides that, the hard-coded version is 0.3.3 (I'm less sure of that - somehow 0.3.4 appears in version.py). Tried to fix these, but got a fail I haven't been able to debug yet, see https://travis-ci.org/roryyorke/Slycot/builds/523641527

…

On Wed, 24 Apr 2019, 09:25 Rene van Paassen ***@***.***> wrote: What happened? I thought I had tweaked setup.py to take the version information from git. If that does not work -- e.g., because the source is tarballed --, it assumes the default hardcoded version (currently 0.3.3, so that must be updated). — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#49 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAA3C7UAUG6VQDUFBJCWBALPSADNPANCNFSM4G67GYDQ> .

roryyorke · 2019-04-24T18:58:12Z

If I try "git archive", I get this error when running setup.py in the unpacked archive:

Traceback (most recent call last):
  File "setup.py", line 248, in <module>
    setup_package()
  File "setup.py", line 179, in setup_package
    VERSION, gitrevision = get_version_info(src_path)
  File "setup.py", line 124, in get_version_info
    FULLVERSION += '.' + str(GIT_CYCLE)
UnboundLocalError: local variable 'GIT_CYCLE' referenced before assignment

Do we want "python setup.py sdist" to work? It seems not to; only some files are packaged.

roryyorke · 2019-05-01T06:03:55Z

@murrayrm, thanks for the pointer to the release instructions, they are helpful

Remaining tasks:

don't know if this builds on OSX - @murraym, are you able to check this?
adding PRs, issues to release notes -- I'll do this
tagging and releasing -- I'll do this
pypi - @murrayrm, I think you're the only one who can do this
conda-forge - this is between @repagh and @moorepants
python-control-announce -- can anyone post here?

murrayrm · 2019-05-01T23:34:34Z

@roryyorke Updates on my end:

MacOS: I was able to compile and install the 0.3.4 release candidate (roryyorke/v0.3.4-release) on MacOS 10.14.4 with python 3.6.
PyPI: I can upload the current master to PyPI as v0.3.4. Please confirm this is what is needed. I have made @moorepants a maintainer and can do the same for you and @repagh if you send me your PyPI IDs.
python-control-announce: anyone should be able to post, but I may need to turn off the moderate bit for the post to go ouot. I will approve whatever post comes through and approve as a future poster, so that will streamline things.

murrayrm · 2019-05-02T00:55:05Z

I just checked the master branch on slycot and it appears that there is no v0.3.4 tag. I think this means that if I generate a version on PyPI that it will be tagged as slycot-0.3.3.51, which is not what we want (I think).

I haven't been following things closely, so don't want to tag things until someone says it is OK. Let me know (or just do it). What is required is the following (from the python-control release notes):

git tag -a x.y.z -m "python-control version x.y.z"
git push --tags

I'm fairly sure that has to be done in the master branch of the repository itself (not as a PR).

roryyorke · 2019-05-02T04:10:04Z

Great, thank you. I was waiting to find out about MacOS builds before tagging.

…

On Thu, 02 May 2019, 02:55 Richard Murray ***@***.***> wrote: I just checked the master branch on slycot and it appears that there is no v0.3.4 tag. I think this means that if I generate a version on PyPI that it will be tagged as slycot-0.3.3.51, which is not what we want (I think). I haven't been following things closely, so don't want to tag things until someone says it is OK. Let me know (or just do it). What is required is the following (from the python-control release notes): git tag -a x.y.z -m "python-control version x.y.z" git push --tags I'm fairly sure that has to be done in the master branch of the repository itself (not as a PR). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#49 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAA3C7UOAT2BAUEVNKKTVNTPTI3WTANCNFSM4G67GYDQ> .

murrayrm · 2019-05-03T13:51:33Z

@roryyorke Looks like the tag went through. The version is 0.3.4.0 (rather than 0.3.4). The SHA256 hash is 63e648b2be8c8ba0322a5fe286bdcf0e8d28a0c12e9ab1510f2a8725fc1283ec

roryyorke · 2019-05-03T17:07:51Z

I didn't think about the fourth part of the version number. It's used in the CI and other non-release builds to give the "git commit distance" from the major-minor-patch version. It looks like the python versioning scheme (PEP 440, see https://www.python.org/dev/peps/pep-0440/#id24) allows an arbitrary number of version parts, but more than 3 parts is unusual.

If we need or want a 3-part version number, we can probably still delete the tag and recreate it, or jump straight to 0.3.5 (with no .0).

I'm not sure what that hash you've given is -- it's not a git object ID. If I do "python setup.py sdist", the tar.gz file I get has a sha256sum of 728fce305908819211aaec2f21b57483f67b02dc94116c3e9102deb5e611d0d2 Tarballs include timestamps of files (take a look at tar xvjf slycot-0.3.4.0.tar.gz|grep setup.cfg) , so one would have to fiddle at least those to get reproduceable tarball generation.

murrayrm · 2019-05-03T17:27:25Z

I pulled the SHA256 hash from PyPI, which is what is supposedly needed for conda-forge.

moorepants · 2019-05-03T18:29:46Z

Don't delete the tag. Good rule of thumb is to never delete a tag (or commit) once pushed beyond your personal computer.

If you want to make a new release just make it 3.4.1 that fixes the version number. We have everything built at conda forge from the new pypi tar ball.

roryyorke · 2019-05-03T18:54:30Z

If it's all working, it's probably not necessary for another tag.

I see the 0.3.4 packages at https://anaconda.org/conda-forge/slycot/files, but conda search doesn't find them. I guess there's an index that needs to be updated?

I've just sent the announcement mail, so 0.3.4 is done. If the extra .0 is a problem, please open another issue, and we can release 0.3.5.

moorepants · 2019-05-03T18:55:21Z

Yes, I should have written 0.3.5 not 3.4.1.

roryyorke closed this as completed Apr 23, 2019

roryyorke reopened this Apr 23, 2019

roryyorke mentioned this issue Apr 28, 2019

Fixes for v0.3.4 release #57

Merged

roryyorke closed this as completed May 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bringing out release 0.3.4 #49

Bringing out release 0.3.4 #49

repagh commented Mar 16, 2019

moorepants commented Mar 16, 2019

repagh commented Apr 16, 2019

murrayrm commented Apr 17, 2019

repagh commented Apr 17, 2019 •

edited

Loading

roryyorke commented Apr 17, 2019

repagh commented Apr 17, 2019

repagh commented Apr 17, 2019

roryyorke commented Apr 17, 2019

moorepants commented Apr 17, 2019

moorepants commented Apr 17, 2019

roryyorke commented Apr 18, 2019 •

edited

Loading

repagh commented Apr 18, 2019

roryyorke commented Apr 23, 2019

roryyorke commented Apr 23, 2019

murrayrm commented Apr 23, 2019

repagh commented Apr 24, 2019

roryyorke commented Apr 24, 2019 via email

roryyorke commented Apr 24, 2019

roryyorke commented May 1, 2019

murrayrm commented May 1, 2019

murrayrm commented May 2, 2019

roryyorke commented May 2, 2019 via email

murrayrm commented May 3, 2019 •

edited

Loading

roryyorke commented May 3, 2019

murrayrm commented May 3, 2019

moorepants commented May 3, 2019

roryyorke commented May 3, 2019

moorepants commented May 3, 2019

Bringing out release 0.3.4 #49

Bringing out release 0.3.4 #49

Comments

repagh commented Mar 16, 2019

moorepants commented Mar 16, 2019

repagh commented Apr 16, 2019

murrayrm commented Apr 17, 2019

repagh commented Apr 17, 2019 • edited Loading

roryyorke commented Apr 17, 2019

repagh commented Apr 17, 2019

repagh commented Apr 17, 2019

roryyorke commented Apr 17, 2019

moorepants commented Apr 17, 2019

moorepants commented Apr 17, 2019

roryyorke commented Apr 18, 2019 • edited Loading

New features

ag08bd Process system pencil to find multivariable zeros

sb10jd Convert descriptor to non-descriptor form

tg01ad Balance system pencil

tg01fd SVD-like coordinate form of system pencil

Build

Testing

Pull requests and issues associated with the release

repagh commented Apr 18, 2019

roryyorke commented Apr 23, 2019

roryyorke commented Apr 23, 2019

murrayrm commented Apr 23, 2019

repagh commented Apr 24, 2019

roryyorke commented Apr 24, 2019 via email

roryyorke commented Apr 24, 2019

roryyorke commented May 1, 2019

murrayrm commented May 1, 2019

murrayrm commented May 2, 2019

roryyorke commented May 2, 2019 via email

murrayrm commented May 3, 2019 • edited Loading

roryyorke commented May 3, 2019

murrayrm commented May 3, 2019

moorepants commented May 3, 2019

roryyorke commented May 3, 2019

moorepants commented May 3, 2019

repagh commented Apr 17, 2019 •

edited

Loading

roryyorke commented Apr 18, 2019 •

edited

Loading

murrayrm commented May 3, 2019 •

edited

Loading