Implement directory filter for extract #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kinshukdua Can I ask you to review this (as the last person to attempt implementing this in #813)? :) Just so I haven't made any extra silly mistakes here... |
Co-authored-by: Kinshuk Dua <[email protected]>
akx
force-pushed
the
extract-ignore-dirs
branch
from
fd278bc
to
1984ec7
Compare
Codecov Report
@@ Coverage Diff @@
## master #832 +/- ##
==========================================
+ Coverage 91.09% 91.13% +0.03%
==========================================
Files 23 23
Lines 4123 4139 +16
==========================================
+ Hits 3756 3772 +16
Misses 367 367
Continue to review full report at Codecov.
|
|
@akx Yes sure, I'll have a look at it! |
m-aciek
added a commit
to m-aciek/babel
that referenced
this pull request
Jan 29, 2023
akx
pushed a commit
that referenced
this pull request
Feb 3, 2023
Edwin18
added a commit
to Edwin18/babel
that referenced
this pull request
Dec 22, 2023
Previosly in function was passed raw value 'self.ignore_dirs', not a list as expected 'ignore_dirs'. Fixes for python-babel#832
Merged
Edwin18
added a commit
to Edwin18/babel
that referenced
this pull request
Dec 22, 2023
Adds multiple value for proper test. Fixes for python-babel#832
akx
pushed a commit
to Edwin18/babel
that referenced
this pull request
Apr 15, 2024
Previosly in function was passed raw value 'self.ignore_dirs', not a list as expected 'ignore_dirs'. Fixes for python-babel#832
akx
pushed a commit
to Edwin18/babel
that referenced
this pull request
Apr 15, 2024
Adds multiple value for proper test. Fixes for python-babel#832
akx
pushed a commit
to Edwin18/babel
that referenced
this pull request
Jul 11, 2024
Adds multiple value for proper test. Fixes for python-babel#832
akx
pushed a commit
that referenced
this pull request
Jul 11, 2024
Adds multiple value for proper test. Follows up on #832
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
directory_filtercallback argument toextract_from_dirthat defaults to the current behavior of ignoring dot and underscore directories--ignore-dirs(that can be repeated) to replace the default.*/_*filtering with other patternsFixes #53 – set
--ignore-dirsto disable the default dot and underscore filtersFixes #402 – implements it :)
Refs #124 – there is still no way to set this in the mapping configuration file, though (that's #694)
Refs #253 – one could now
--ignore-dirs=node_modules, for instance.Refs #694 – could be reimplemented on top of this
directory_filter?Closes #447 – supersedes it
Closes #563 – supersedes it
Closes #761 – you can set
--ignore-dirs='.*'Closes #813 – supersedes it (thanks for the wording for the CLI parameter!)
Closes #793 – you can set
--ignore-dirs='.* _* venv'