fix #53 (now directories starting with '_' are not ignored) #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #761 +/- ##
=======================================
Coverage 91.12% 91.12%
=======================================
Files 24 24
Lines 4180 4180
=======================================
Hits 3809 3809
Misses 371 371
Continue to review full report at Codecov.
|
gladykov
reviewed
Jun 12, 2021
| @@ -139,7 +139,7 @@ def extract_from_dir(dirname=None, method_map=DEFAULT_MAPPING, | |||
| for root, dirnames, filenames in os.walk(absname): | |||
| dirnames[:] = [ | |||
| subdir for subdir in dirnames | |||
| if not (subdir.startswith('.') or subdir.startswith('_')) | |||
| if not (subdir.startswith('.') or subdir == '_') | |||
There was a problem hiding this comment.
Your PR does not make sense.
>>> a = "_"
>>> a.startswith("_")
True
>>>
There was a problem hiding this comment.
Please, consider reading the issue thread attached (this one).
In my PR description, I didn't clarify what exactly I tried to fix - that's my fault.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a small issue, when babel ignored directories starting with
_.I thought that it's still a good idea to ignore dirs whose entire name is
_.