Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional potential systemctl exit status for Ubuntu 24 #776

Closed
wants to merge 1 commit into from

Conversation

pfuntner
Copy link

@pfuntner pfuntner commented Sep 13, 2024

This is a simple change to SystemdService.is_running() to allow it to work for Ubuntu 24 to correct the symptoms in #775.

On Ubuntu 24, systemctl is-activate foobar (assuming foobar is an unknown service) has an exit status of 4 but the is_running() method only expects exit status values of 0, 1, or 3. My change just allows an exit status of 4 as well. The method will return False anyway but it won't raise the AssertionError.

I was following CONTRIBUTING.rst and tried running tox from a virtual environment on my development machine but it failed and I'm not sure how to fix it. Here's the output: tox output.txt.

@pfuntner
Copy link
Author

It looks like the tox tests were run automatically on the Github side. I didn't expect my tiny change would introduce a problem and I see it worked. 🥳

@martinhoyer
Copy link
Contributor

There is already #773, just no reviewers it seems :(

@pfuntner
Copy link
Author

There is already #773, just no reviewers it seems :(

Oh, great. Thanks, I'll close this one.

@pfuntner pfuntner closed this Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants