Skip to content

Conversation

arossert
Copy link

@arossert arossert commented Jul 2, 2024

A fix for this issue
#748

@pfuntner
Copy link

I'd like to see this fixed. It's affecting a project with which I'm involved at work (#775). I suppose I'll have to do some lame workarounds. :-(

@martinhoyer
Copy link
Contributor

@philpep Hi Philippe, is this project looking for maintainers/reviewers? Seems like the open PRs are a bit stuck..

@permanentdaylight
Copy link

@martinhoyer

This also applies to is_enabled, might be a good idea to get a fix in for that too.

@ltog
Copy link

ltog commented Jan 14, 2025

I am affected by this too. I checked the changes and they look fine to me.

@philpep philpep force-pushed the fix-systemctl-is-active branch from 149f42e to 4018bdd Compare March 29, 2025 13:36
Copy link
Contributor

@philpep philpep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think previous behavior (AssertionError) was fine. But I'm also fine with the new proposed behavior. so LGTM.

@philpep philpep merged commit 23e9351 into pytest-dev:main Mar 29, 2025
7 checks passed
@philpep
Copy link
Contributor

philpep commented Mar 29, 2025

Merged, thanks!

@permanentdaylight
Copy link

Thanks @philpep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants