-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typing and update to mypy 1.8.0 #769
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #769 +/- ##
==========================================
+ Coverage 94.33% 94.35% +0.01%
==========================================
Files 2 2
Lines 477 478 +1
Branches 95 96 +1
==========================================
+ Hits 450 451 +1
Misses 17 17
Partials 10 10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thank you for the patch.
I'll rebase and add a changelog entry, so we can get this out in a pre-release right away.
This allows mypy to distinguish between the different conftests.py files when running `mypy tests/`, and it's also preferable in general.
Signed-off-by: Michael Seifert <[email protected]>
…t 7 has been dropped. Signed-off-by: Michael Seifert <[email protected]>
Signed-off-by: Michael Seifert <[email protected]>
When reading the code I noticed the line
_event_loop_fixture_id = StashKey[str]
which should be_event_loop_fixture_id = StashKey[str]()
(an instance). I wondered how come mypy didn't complain, and the reason is that pytest wasn't installed in the pre-commit mypy environment.This PR:
mypy tests/
by makestests/
a package (adding__init__.py
files)