Update mypy pre-commit hook #596
Labels
Milestone
Comments
efiop
added a commit
to efiop/adlfs
that referenced
this issue
Dec 22, 2023
With newer versions we get a lot of errors like:
```
____________________________ test_isfile_versioned _____________________________
self = <Coroutine test_isfile_versioned>
def runtest(self) -> None:
self.obj = wrap_in_sync(
# pytest-dev/pytest-asyncio#596
self.obj, # type: ignore[has-type]
)
> super().runtest()
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pytest_asyncio/plugin.py:431:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pytest_asyncio/plugin.py:879: in inner
_loop.run_until_complete(task)
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/asyncio/base_events.py:592: in run_until_complete
self._check_running()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <_UnixSelectorEventLoop running=True closed=False debug=False>
def _check_running(self):
if self.is_running():
> raise RuntimeError('This event loop is already running')
E RuntimeError: This event loop is already running
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/asyncio/base_events.py:552: RuntimeError
```
Don't know precise reason and maybe using nest-asyncio package would fix that, but for now
just pinning older version to move forward.
efiop
added a commit
to fsspec/adlfs
that referenced
this issue
Dec 22, 2023
With newer versions we get a lot of errors like:
```
____________________________ test_isfile_versioned _____________________________
self = <Coroutine test_isfile_versioned>
def runtest(self) -> None:
self.obj = wrap_in_sync(
# pytest-dev/pytest-asyncio#596
self.obj, # type: ignore[has-type]
)
> super().runtest()
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pytest_asyncio/plugin.py:431:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pytest_asyncio/plugin.py:879: in inner
_loop.run_until_complete(task)
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/asyncio/base_events.py:592: in run_until_complete
self._check_running()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <_UnixSelectorEventLoop running=True closed=False debug=False>
def _check_running(self):
if self.is_running():
> raise RuntimeError('This event loop is already running')
E RuntimeError: This event loop is already running
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/asyncio/base_events.py:552: RuntimeError
```
Don't know precise reason and maybe using nest-asyncio package would fix that, but for now
just pinning older version to move forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When bumping the version of the pre-commit hooks with
pre-commit autoupdate, mypy reports typing errors.The goal of this issue is to update the mypy pre-commit hook (and ideally all others) to the most recent version. At the same time, any new typing error should be addressed.
The text was updated successfully, but these errors were encountered: