fix: add missing properties to AlignedSegment type stubs #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msto
changed the title
|
These were added while the type hints PR #1008 was still in flight. So it is more that the latter was (understandably) not updated with additions on master before it was itself merged. In any case, thanks for the useful contribution. I've checked for other additions while the type hints were gestating — there were two, and I've added type stubs for them to your branch. |
jmarshall
approved these changes
Apr 19, 2024
|
Thanks @jmarshall ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1088 added
is_mappedandis_forward(and their mate equivalents) to theAlignedSegmentAPI, but didn't declare these properties in the corresponding type stubs. Their absence here causes downstream woes with mypy's type checking