-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforcing total project size limit(user-facing changes) #8129
Merged
di
merged 24 commits into
pypi:master
from
VikramJayanthi17:limit-proj-total-size-user-facing
Jun 26, 2020
Merged
Enforcing total project size limit(user-facing changes) #8129
di
merged 24 commits into
pypi:master
from
VikramJayanthi17:limit-proj-total-size-user-facing
Jun 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
di
reviewed
Jun 19, 2020
Co-authored-by: Dustin Ingram <[email protected]>
Co-authored-by: Dustin Ingram <[email protected]>
Co-authored-by: Dustin Ingram <[email protected]>
Co-authored-by: Dustin Ingram <[email protected]>
…m/VikramJayanthi17/warehouse into limit-proj-total-size-user-facing merging old changes
pradyunsg
reviewed
Jun 24, 2020
pradyunsg
reviewed
Jun 24, 2020
pradyunsg
reviewed
Jun 24, 2020
VikramJayanthi17
force-pushed
the
limit-proj-total-size-user-facing
branch
from
June 24, 2020 19:08
2d3e6f0
to
51200b6
Compare
pradyunsg
reviewed
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #7446, I implemented the enforcement of the total project size limit. The enforcement takes place in
legacy.py
infile_upload
and the help url shows them how to create an issue onpypi-support
using the existingfile_upload_limit
issue template(this should be changed to have the appropriate information/steps) to request a larger total project size limit or an exemption. This assumes a default limit of 100GB(as mentioned in #7446 by @di this is up for debate). The ability for admins to change the limit for projects is in a separate PR(#8128).Please let me know if you all have any suggestions/changes, thanks.
Fixes #7446.