Ability to add total project size limit(internal changes) #8128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 17, 2020 18:43
VikramJayanthi17
force-pushed
the
limit-proj-total-size-internal
branch
from
30c71b1
to
d2eeb9e
Compare
di
reviewed
Jun 19, 2020
Co-authored-by: Dustin Ingram <[email protected]>
Co-authored-by: Dustin Ingram <[email protected]>
Co-authored-by: Dustin Ingram <[email protected]>
Co-authored-by: Dustin Ingram <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #7446, I implemented a way for admins to add custom limits to a project's total size with 100 GB being the default. This is done through the admin dashboard, similar to how the file upload limit is set. It also displays the total size limit of the project underneath the upload limit. I have separated the internal functionality(to set the limit) from the enforcement(user-facing) so that projects that are above the default may be "grandfathered" into their higher limits before enforcement stops them from uploading more distributions.
A separate PR will include the user-facing changes to be made(the actual enforcement of the limit , the appropriate output, and a help section on how to get a higher limit/exemption).
Please let me know if you all have any suggestions/changes, thanks.