Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only editable entry should trigger editable installs #6069

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

matteius
Copy link
Member

Exploration of #6054

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@matteius matteius force-pushed the utilize-editable-entry-during-install branch from afbec22 to 8f96c41 Compare January 28, 2024 16:50
@matteius matteius marked this pull request as ready for review February 1, 2024 09:16
@matteius matteius merged commit 23dbe27 into main Feb 1, 2024
11 of 19 checks passed
@matteius matteius deleted the utilize-editable-entry-during-install branch February 1, 2024 09:35
@edmorley
Copy link
Contributor

edmorley commented Feb 1, 2024

Thank you for fixing this.

I notice no testcase was added - I feel like the current rate of regressions in pipenv releases is pretty high, and I'm not sure that will improve unless test coverage is also improved?

@matteius
Copy link
Member Author

matteius commented Feb 1, 2024

@edmorley if you look back on the issue that is still marked open, no one has responded to me when I ask for more details like what the difference even is between a editable and non editable local file install--

#6054 (comment)

I'm not opposed to adding test cases, however I think if you look you'll see I've added the most new test cases in the last two years, and the test runner used to take 45 minutes plus, now takes a fraction of the time, wasn't without a lot of hard effort. Yes the test runner needs more cases and more TLC, no I cannot be the one to ensure all those tests exist. I've refactored and simplified a lot of code in pipenv, and I often get caught by the lack of tests that already existed around original functionality folks expects. It is easy to ask for more tests, harder to implement them. I've spent hours at points trying to add tests for some things only to back them out for reasons due to the nature of trying to test some of this stuff.

@matteius
Copy link
Member Author

matteius commented Feb 1, 2024

Like I am not even convinced it is fixed, that is why I left the original issue open. But I thought this is a step on the path.

github-merge-queue bot pushed a commit to NomicFoundation/slang that referenced this pull request Feb 3, 2024
Bumps the non-major-dependencies group with 1 update:
[pipenv](https://github.com/pypa/pipenv).

Updates `pipenv` from 2023.2.18 to 2023.12.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/pypa/pipenv/releases">pipenv's
releases</a>.</em></p>
<blockquote>
<h2>Release v2023.12.0</h2>
<h2>What's Changed</h2>
<ul>
<li>NOTE: this is our second semver release with a plan to release major
version 3000 later this winter/Spring.</li>
<li>Convert from pydantic to vanilla dataclasses (includes pythonfinder
2.1.0) by <a
href="https://github.com/matteius"><code>@​matteius</code></a> in <a
href="https://github.com/pypa/pipenv/pull/6065">pypa/pipenv#6065</a></li>
<li>Remove forcing CI code path to use nt shell code path by <a
href="https://github.com/matteius"><code>@​matteius</code></a> in <a
href="https://github.com/pypa/pipenv/pull/6072">pypa/pipenv#6072</a></li>
<li>Only editable entry should trigger editable installs by <a
href="https://github.com/matteius"><code>@​matteius</code></a> in <a
href="https://github.com/pypa/pipenv/pull/6069">pypa/pipenv#6069</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/pypa/pipenv/compare/v2023.11.17...v2023.12.0">https://github.com/pypa/pipenv/compare/v2023.11.17...v2023.12.0</a></p>
<h2>Release v2023.11.17</h2>
<h2>What's Changed</h2>
<ul>
<li>Vendor latest tomlkit by <a
href="https://github.com/deivid-rodriguez"><code>@​deivid-rodriguez</code></a>
in <a
href="https://github.com/pypa/pipenv/pull/6024">pypa/pipenv#6024</a></li>
<li>Chore: Resolve CI deprecation warnings by <a
href="https://github.com/stumpylog"><code>@​stumpylog</code></a> in <a
href="https://github.com/pypa/pipenv/pull/6025">pypa/pipenv#6025</a></li>
<li>Fix the issue(<a
href="https://github.com/pypa/pipenv/issues/6022">#6022</a>):
Add additional installation method in README by <a
href="https://github.com/y-vectorfield"><code>@​y-vectorfield</code></a>
in <a
href="https://github.com/pypa/pipenv/pull/6023">pypa/pipenv#6023</a></li>
<li>Make <code>project.get_default_index()</code> populate a default
name by <a
href="https://github.com/deivid-rodriguez"><code>@​deivid-rodriguez</code></a>
in <a
href="https://github.com/pypa/pipenv/pull/6021">pypa/pipenv#6021</a></li>
<li>Drop markupsafe - way too late for that by <a
href="https://github.com/oz123"><code>@​oz123</code></a> in <a
href="https://github.com/pypa/pipenv/pull/6033">pypa/pipenv#6033</a></li>
<li>Fix for the safety test failure in the CI by <a
href="https://github.com/matteius"><code>@​matteius</code></a> in <a
href="https://github.com/pypa/pipenv/pull/6038">pypa/pipenv#6038</a></li>
<li>Add markers to Pipfile when parsing requirements.txt by <a
href="https://github.com/geonik-code"><code>@​geonik-code</code></a> in
<a
href="https://github.com/pypa/pipenv/pull/6008">pypa/pipenv#6008</a></li>
<li>Fixed a bug with locking packages with non canonical names by <a
href="https://github.com/mangin"><code>@​mangin</code></a> in <a
href="https://github.com/pypa/pipenv/pull/6057">pypa/pipenv#6057</a></li>
<li>Bump jinja2 from 3.1.2 to 3.1.3 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://github.com/pypa/pipenv/pull/6059">pypa/pipenv#6059</a></li>
<li>Vendor bump pipdeptree by <a
href="https://github.com/oz123"><code>@​oz123</code></a> in <a
href="https://github.com/pypa/pipenv/pull/6055">pypa/pipenv#6055</a></li>
<li>updated readme by <a
href="https://github.com/Suprithvarma1"><code>@​Suprithvarma1</code></a>
in <a
href="https://github.com/pypa/pipenv/pull/6049">pypa/pipenv#6049</a></li>
<li>Update release script to enforce semver going forward in 2024 by <a
href="https://github.com/matteius"><code>@​matteius</code></a> in <a
href="https://github.com/pypa/pipenv/pull/6052">pypa/pipenv#6052</a></li>
<li>Vendoring in pip-23.3.2 by <a
href="https://github.com/matteius"><code>@​matteius</code></a> in <a
href="https://github.com/pypa/pipenv/pull/6064">pypa/pipenv#6064</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a
href="https://github.com/deivid-rodriguez"><code>@​deivid-rodriguez</code></a>
made their first contribution in <a
href="https://github.com/pypa/pipenv/pull/6024">pypa/pipenv#6024</a></li>
<li><a href="https://github.com/stumpylog"><code>@​stumpylog</code></a>
made their first contribution in <a
href="https://github.com/pypa/pipenv/pull/6025">pypa/pipenv#6025</a></li>
<li><a
href="https://github.com/geonik-code"><code>@​geonik-code</code></a>
made their first contribution in <a
href="https://github.com/pypa/pipenv/pull/6008">pypa/pipenv#6008</a></li>
<li><a href="https://github.com/mangin"><code>@​mangin</code></a> made
their first contribution in <a
href="https://github.com/pypa/pipenv/pull/6057">pypa/pipenv#6057</a></li>
<li><a
href="https://github.com/Suprithvarma1"><code>@​Suprithvarma1</code></a>
made their first contribution in <a
href="https://github.com/pypa/pipenv/pull/6049">pypa/pipenv#6049</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/pypa/pipenv/compare/v2023.11.15...v2023.11.17">https://github.com/pypa/pipenv/compare/v2023.11.15...v2023.11.17</a></p>
<h2>Release v2023.11.15</h2>
<h2>What's Changed</h2>
<ul>
<li>Treat all return paths of this method as strings by <a
href="https://github.com/matteius"><code>@​matteius</code></a> in <a
href="https://github.com/pypa/pipenv/pull/6017">pypa/pipenv#6017</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/pypa/pipenv/compare/v2023.11.14...v2023.11.15">https://github.com/pypa/pipenv/compare/v2023.11.14...v2023.11.15</a></p>
<h2>Release v2023.11.14</h2>
<h2>What's Changed</h2>
<ul>
<li>Restore this code that should prevent the string has no attribute
update bug. by <a
href="https://github.com/matteius"><code>@​matteius</code></a> in <a
href="https://github.com/pypa/pipenv/pull/6007">pypa/pipenv#6007</a></li>
<li>Pass through pipfile index urls when creating https session so that
keyring fully works by <a
href="https://github.com/mungojam"><code>@​mungojam</code></a> in <a
href="https://github.com/pypa/pipenv/pull/5994">pypa/pipenv#5994</a></li>
<li>Fix issue-6011 direct file url path by <a
href="https://github.com/matteius"><code>@​matteius</code></a> in <a
href="https://github.com/pypa/pipenv/pull/6012">pypa/pipenv#6012</a></li>
<li>Ignore existing venv dir when PIPENV_VENV_IN_PROJECT is false by <a
href="https://github.com/arnaud-dezandee"><code>@​arnaud-dezandee</code></a>
in <a
href="https://github.com/pypa/pipenv/pull/6009">pypa/pipenv#6009</a></li>
<li>Assume that vcs and direct URL installs need to be reinstalled by <a
href="https://github.com/matteius"><code>@​matteius</code></a> in <a
href="https://github.com/pypa/pipenv/pull/5936">pypa/pipenv#5936</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/pypa/pipenv/blob/main/CHANGELOG.md">pipenv's
changelog</a>.</em></p>
<blockquote>
<h1>2023.12.0 (2024-02-01)</h1>
<h1>Pipenv 2023.12.0 (2024-02-01)</h1>
<h2>Bug Fixes</h2>
<ul>
<li>Removal of pydantic from pythonfinder and pipenv; reduced complexity
of pythonfinder pathlib usage (avoid posix conversions).
<code>[#6065](pypa/pipenv#6065)
&lt;https://github.com/pypa/pipenv/issues/6065&gt;</code>_</li>
<li>Adjusted logic which assumed any file, path or VCS install should be
considered editable. Instead relies on the user specified editable flag
to mark requirement as editable install.
<code>[#6069](pypa/pipenv#6069)
&lt;https://github.com/pypa/pipenv/issues/6069&gt;</code>_</li>
<li>Remove logic that treats <code>CI</code> variable to use
<code>do_run_nt</code> shell logic, as the original reasons for that
patch were no longer valid.
<code>[#6072](pypa/pipenv#6072)
&lt;https://github.com/pypa/pipenv/issues/6072&gt;</code>_
2023.11.17 (2024-01-21)
=======================
Pipenv 2023.11.17 (2024-01-21)
==============================</li>
</ul>
<h2>Bug Fixes</h2>
<ul>
<li>Add markers to Pipfile when parsing requirements.txt
<code>[#6008](pypa/pipenv#6008)
&lt;https://github.com/pypa/pipenv/issues/6008&gt;</code>_</li>
<li>Fix KeyError when using a source without a name in Pipfile
<code>[#6021](pypa/pipenv#6021)
&lt;https://github.com/pypa/pipenv/issues/6021&gt;</code>_</li>
<li>Fix a bug with locking projects that contains packages with non
canonical names from private indexes
<code>[#6056](pypa/pipenv#6056)
&lt;https://github.com/pypa/pipenv/issues/6056&gt;</code>_</li>
</ul>
<h2>Vendored Libraries</h2>
<ul>
<li>Update vendored tomlkit to <code>0.12.3</code>
<code>[#6024](pypa/pipenv#6024)
&lt;https://github.com/pypa/pipenv/issues/6024&gt;</code>_</li>
<li>Bump version of pipdeptree to 0.13.2
<code>[#6055](pypa/pipenv#6055)
&lt;https://github.com/pypa/pipenv/issues/6055&gt;</code>_
2023.11.15 (2023-11-15)
=======================
Pipenv 2023.11.15 (2023-11-15)
==============================</li>
</ul>
<h2>Bug Fixes</h2>
<ul>
<li>Fix regression with path installs on most recent release
<code>2023.11.14</code>
<code>[#6017](pypa/pipenv#6017)
&lt;https://github.com/pypa/pipenv/issues/6017&gt;</code>_</li>
</ul>
<h1>2023.11.14 (2023-11-14)</h1>
<h1>Pipenv 2023.11.14 (2023-11-14)</h1>
<h2>Behavior Changes</h2>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/pypa/pipenv/commit/d4483dd2a3cd55c45de2e3d5ca98094c67b64af3"><code>d4483dd</code></a>
Release v2023.12.0</li>
<li><a
href="https://github.com/pypa/pipenv/commit/e26edd59a6f8486cf24038b248eeb65f9d9147f9"><code>e26edd5</code></a>
Bumped version to 2023.12.0.</li>
<li><a
href="https://github.com/pypa/pipenv/commit/23dbe27544ed159b9ab3b5b988439dd08483ef3c"><code>23dbe27</code></a>
Only editable entry should trigger editable installs (<a
href="https://github.com/pypa/pipenv/issues/6069">#6069</a>)</li>
<li><a
href="https://github.com/pypa/pipenv/commit/15149f0091c757689249aee04a6afc87895289a3"><code>15149f0</code></a>
Remove forcing CI code path to use nt shell code path (<a
href="https://github.com/pypa/pipenv/issues/6072">#6072</a>)</li>
<li><a
href="https://github.com/pypa/pipenv/commit/95df3fd6495544eed7835fbf677069d401d3ed9d"><code>95df3fd</code></a>
Convert from pydantic to vanilla dataclasses (includes pythonfinder
2.1.0) (#...</li>
<li><a
href="https://github.com/pypa/pipenv/commit/2bd7eab65e3644ac44a1dda2809fa6e9e046b286"><code>2bd7eab</code></a>
Fix release CI step for next release</li>
<li><a
href="https://github.com/pypa/pipenv/commit/7a640f21266efac7c530c772ebabf08ee0a7e1f1"><code>7a640f2</code></a>
Release v2023.11.17</li>
<li><a
href="https://github.com/pypa/pipenv/commit/d202fac429fb9f9959767ce7ae48d88c307e23cd"><code>d202fac</code></a>
Bumped version to 2023.11.17.</li>
<li><a
href="https://github.com/pypa/pipenv/commit/542554e4e84da228fa42aed34c60747c2b051fff"><code>542554e</code></a>
upgrade sphinx due to release script bug</li>
<li><a
href="https://github.com/pypa/pipenv/commit/624ec01ef385cf36a84938d2a097e1819a01cbb9"><code>624ec01</code></a>
Vendoring in pip-23.3.2 (<a
href="https://github.com/pypa/pipenv/issues/6064">#6064</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/pypa/pipenv/compare/v2023.2.18...v2023.12.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pipenv&package-manager=pip&previous-version=2023.2.18&new-version=2023.12.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
achim-k pushed a commit to foxglove/ws-protocol that referenced this pull request Feb 5, 2024
Bumps [pipenv](https://github.com/pypa/pipenv) from 2023.11.17 to
2023.12.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/pypa/pipenv/releases">pipenv's
releases</a>.</em></p>
<blockquote>
<h2>Release v2023.12.1</h2>
<h2>What's Changed</h2>
<ul>
<li>Issue-6079 Remove debug print statements that mistakenly got
released by <a
href="https://github.com/matteius"><code>@​matteius</code></a> in <a
href="https://github.com/pypa/pipenv/pull/6082">pypa/pipenv#6082</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/pypa/pipenv/compare/v2023.12.0...v2023.12.1">https://github.com/pypa/pipenv/compare/v2023.12.0...v2023.12.1</a></p>
<h2>Release v2023.12.0</h2>
<h2>What's Changed</h2>
<ul>
<li>NOTE: this is our second semver release with a plan to release major
version 3000 later this winter/Spring.</li>
<li>Convert from pydantic to vanilla dataclasses (includes pythonfinder
2.1.0) by <a
href="https://github.com/matteius"><code>@​matteius</code></a> in <a
href="https://github.com/pypa/pipenv/pull/6065">pypa/pipenv#6065</a></li>
<li>Remove forcing CI code path to use nt shell code path by <a
href="https://github.com/matteius"><code>@​matteius</code></a> in <a
href="https://github.com/pypa/pipenv/pull/6072">pypa/pipenv#6072</a></li>
<li>Only editable entry should trigger editable installs by <a
href="https://github.com/matteius"><code>@​matteius</code></a> in <a
href="https://github.com/pypa/pipenv/pull/6069">pypa/pipenv#6069</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/pypa/pipenv/compare/v2023.11.17...v2023.12.0">https://github.com/pypa/pipenv/compare/v2023.11.17...v2023.12.0</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/pypa/pipenv/blob/main/CHANGELOG.md">pipenv's
changelog</a>.</em></p>
<blockquote>
<h1>2023.12.1 (2024-02-04)</h1>
<h1>Pipenv 2023.12.1 (2024-02-04)</h1>
<h2>Bug Fixes</h2>
<ul>
<li>Remove debug print statements that should not have made it into the
last release. <code>[#6079](pypa/pipenv#6079)
&lt;https://github.com/pypa/pipenv/issues/6079&gt;</code>_
2023.12.0 (2024-02-01)
======================
Pipenv 2023.12.0 (2024-02-01)
=============================</li>
</ul>
<h2>Bug Fixes</h2>
<ul>
<li>Removal of pydantic from pythonfinder and pipenv; reduced complexity
of pythonfinder pathlib usage (avoid posix conversions).
<code>[#6065](pypa/pipenv#6065)
&lt;https://github.com/pypa/pipenv/issues/6065&gt;</code>_</li>
<li>Adjusted logic which assumed any file, path or VCS install should be
considered editable. Instead relies on the user specified editable flag
to mark requirement as editable install.
<code>[#6069](pypa/pipenv#6069)
&lt;https://github.com/pypa/pipenv/issues/6069&gt;</code>_</li>
<li>Remove logic that treats <code>CI</code> variable to use
<code>do_run_nt</code> shell logic, as the original reasons for that
patch were no longer valid.
<code>[#6072](pypa/pipenv#6072)
&lt;https://github.com/pypa/pipenv/issues/6072&gt;</code>_</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/pypa/pipenv/commit/80363b9374fbd2eab2284b05e7f5d994540012be"><code>80363b9</code></a>
Release v2023.12.1</li>
<li><a
href="https://github.com/pypa/pipenv/commit/c69d3ba0b666c4845697da5ed6d890bc5c54c201"><code>c69d3ba</code></a>
Bumped version to 2023.12.1.</li>
<li><a
href="https://github.com/pypa/pipenv/commit/ddf548c0e34ce9948232c20bd67091dcb7a3bb7d"><code>ddf548c</code></a>
Add news</li>
<li><a
href="https://github.com/pypa/pipenv/commit/686ad951afee87a469ecaa663540267158ba86ac"><code>686ad95</code></a>
remove debug print statements that should not have made it into the last
rele...</li>
<li><a
href="https://github.com/pypa/pipenv/commit/d4483dd2a3cd55c45de2e3d5ca98094c67b64af3"><code>d4483dd</code></a>
Release v2023.12.0</li>
<li><a
href="https://github.com/pypa/pipenv/commit/e26edd59a6f8486cf24038b248eeb65f9d9147f9"><code>e26edd5</code></a>
Bumped version to 2023.12.0.</li>
<li><a
href="https://github.com/pypa/pipenv/commit/23dbe27544ed159b9ab3b5b988439dd08483ef3c"><code>23dbe27</code></a>
Only editable entry should trigger editable installs (<a
href="https://github.com/pypa/pipenv/issues/6069">#6069</a>)</li>
<li><a
href="https://github.com/pypa/pipenv/commit/15149f0091c757689249aee04a6afc87895289a3"><code>15149f0</code></a>
Remove forcing CI code path to use nt shell code path (<a
href="https://github.com/pypa/pipenv/issues/6072">#6072</a>)</li>
<li><a
href="https://github.com/pypa/pipenv/commit/95df3fd6495544eed7835fbf677069d401d3ed9d"><code>95df3fd</code></a>
Convert from pydantic to vanilla dataclasses (includes pythonfinder
2.1.0) (#...</li>
<li><a
href="https://github.com/pypa/pipenv/commit/2bd7eab65e3644ac44a1dda2809fa6e9e046b286"><code>2bd7eab</code></a>
Fix release CI step for next release</li>
<li>See full diff in <a
href="https://github.com/pypa/pipenv/compare/v2023.11.17...v2023.12.1">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pipenv&package-manager=pip&previous-version=2023.11.17&new-version=2023.12.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants