Skip to content

Commit

Permalink
Only editable entry should trigger editable installs (#6069)
Browse files Browse the repository at this point in the history
* Only editable entry should trigger editable installs

* add news fragment
  • Loading branch information
matteius authored Feb 1, 2024
1 parent 15149f0 commit 23dbe27
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 1 addition & 0 deletions news/6069.bugfix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Adjusted logic which assumed any file, path or VCS install should be considered editable. Instead relies on the user specified editable flag to mark requirement as editable install.
4 changes: 1 addition & 3 deletions pipenv/utils/dependencies.py
Original file line number Diff line number Diff line change
Expand Up @@ -1207,9 +1207,7 @@ def is_required_version(version, specified_version):

def is_editable(pipfile_entry):
if hasattr(pipfile_entry, "get"):
return pipfile_entry.get("editable", False) or any(
pipfile_entry.get(key) for key in ("file", "path") + VCS_LIST
)
return pipfile_entry.get("editable", False)
return False


Expand Down

0 comments on commit 23dbe27

Please sign in to comment.