-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support --no-isolation with build[uv] #1889
Conversation
It looks to me like you're just disabling uv support when |
We still install everything via uv when |
Ah, got it. Understood! |
If I add a utility for this, it will clash with #1873, so let's do this as a quick fix, and then write a utility later that tries to be smarter for combined flags. |
I think we could release after this. Would like to get b3 out! |
I don't think it's necessary but a note / caution shall be added in the docs then. |
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
d61bffb
to
df0afe1
Compare
I cancelled Travis CI to get some time for manylinux. CentOS 7 reached End-Of-Life so mirrors shall be updated on manylinux2014. IMHO, we should wait for the new images before the release. |
* fix: support --no-isolation with build[uv] Signed-off-by: Henry Schreiner <[email protected]> * docs: mention caveat Signed-off-by: Henry Schreiner <[email protected]> --------- Signed-off-by: Henry Schreiner <[email protected]>
Fixing #1887. I didn't special case chained short flags, like
-xn
or-nx
, maybe we should?