Skip to content

Fix bug in nuts stats #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aseyboldt merged 1 commit into from
Aug 3, 2017
Merged

Fix bug in nuts stats #2467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pymc3/step_methods/hmc/nuts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,12 +197,12 @@ def astep(self, q0):

for _ in range(max_treedepth):
direction = logbern(np.log(0.5)) * 2 - 1
diverging, turning = tree.extend(direction)
diverging_info, turning = tree.extend(direction)
q, q_grad = tree.proposal.q, tree.proposal.q_grad

if diverging or turning:
if diverging:
self.report._add_divergence(self.tune, *diverging)
if diverging_info or turning:
if diverging_info:
self.report._add_divergence(self.tune, *diverging_info)
break

w = 1. / (self.m + self.t0)
Expand All @@ -223,7 +223,7 @@ def astep(self, q0):
'step_size': step_size,
'tune': self.tune,
'step_size_bar': np.exp(self.log_step_size_bar),
'diverging': diverging,
'diverging': bool(diverging_info),
}

stats.update(tree.stats())
Expand Down