Merged
Conversation
Closed
Member
|
while we are on this, I think we should cast effective samples to int as well. |
Member
Author
|
Hm. For some reason there is a test that explicitly checks if it returns a float: https://github.com/pymc-devs/pymc3/blob/master/pymc3/tests/test_diagnostics.py#L192 |
Member
|
Is there any reason for that? Can we change the test to int as well? |
Contributor
|
Is this anything to do with GPU support?
…On 2 Aug 2017 07:45, "Junpeng Lao" ***@***.***> wrote:
Is there any reason for that? Can we change the test to int as well?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2467 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA8DiEgPigbdvZrA2Q_EIATOFtRKYM-pks5sUBrtgaJpZM4OqamT>
.
|
Member
Author
|
@springcoil No, this was just a bit ugly, and led to problems with the hdf5 backend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The values for the sampler stats
divergingshould be a bool, not the whole info tuple. This should fix a problem when using the hdf5 backend (see #2448).