Skip to content

Fix bug in nuts stats#2467

Merged
aseyboldt merged 1 commit intopymc-devs:masterfrom
aseyboldt:fix-nuts-divstats
Aug 3, 2017
Merged

Fix bug in nuts stats#2467
aseyboldt merged 1 commit intopymc-devs:masterfrom
aseyboldt:fix-nuts-divstats

Conversation

@aseyboldt
Copy link
Member

The values for the sampler stats diverging should be a bool, not the whole info tuple. This should fix a problem when using the hdf5 backend (see #2448).

@aseyboldt aseyboldt mentioned this pull request Aug 1, 2017
@junpenglao
Copy link
Member

while we are on this, I think we should cast effective samples to int as well.

@aseyboldt
Copy link
Member Author

Hm. For some reason there is a test that explicitly checks if it returns a float: https://github.com/pymc-devs/pymc3/blob/master/pymc3/tests/test_diagnostics.py#L192

@junpenglao
Copy link
Member

Is there any reason for that? Can we change the test to int as well?

@springcoil
Copy link
Contributor

springcoil commented Aug 2, 2017 via email

@aseyboldt
Copy link
Member Author

aseyboldt commented Aug 3, 2017

@springcoil No, this was just a bit ugly, and led to problems with the hdf5 backend.
I'm merging this, the only test failure is the good old nuts warning problem.

@aseyboldt aseyboldt merged commit 41d70b8 into pymc-devs:master Aug 3, 2017
@aseyboldt aseyboldt deleted the fix-nuts-divstats branch August 3, 2017 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants