Release branch 2.15.1 by Pierre-Sassoulas · Pull Request #7393 · pylint-dev/pylint

Pierre-Sassoulas · 2022-09-01T10:26:43Z

No description provided.

…ecking guard Close pylint-dev#7368

Co-authored-by: orSolocate <38433858+orSolocate@users.noreply.github.com>

Pierre-Sassoulas · 2022-09-01T10:27:55Z

-version = "2.16.0"
+version = "2.15.1"
 directory = "doc/whatsnew/fragments"
-filename = "doc/whatsnew/2/2.16/index.rst"
+filename = "doc/whatsnew/2/2.15/index.rst"


This is going to NOT be a merge conflict and we need to be careful when merging in main.

I was wondering about this. Do we need to bump to the dev version on main? What's the benefit? Can't we just bump when we need to for a release?

Well it's useful to know the pylint version we're talking about (2.16.0-dev0 vs 2.15.1). scm_setuptool was nice for this but created a dependencie we did not want...

Yeah I mean I don't really mind, but referring to main would also work for me.
It reduces the amount of work necessary for a release so I thought it might be something to consider.

referring to main ?

As in, I never use 2.16.0-dev0 directly in any of my messages. I often just say main or something like that. There is not much benefit for me to having the bumped version, but that might just be me.

DanielNoord

Release notes seem to be broken...

Pierre-Sassoulas · 2022-09-01T19:14:57Z

Release notes seem to be broken...

Yes, I was wondering what to do. Maybe use "False positive for 2.15.1" as title ? Maybe remove the titles altogether... ?

Pierre-Sassoulas · 2022-09-01T19:16:24Z

We have titles that are duplicated when we generate the patch release note:

/home/runner/work/pylint/pylint/doc/whatsnew/2/2.15/index.rst:63: WARNING: duplicate label whatsnew/2/2.15/index:false positives fixed, other instance in /home/runner/work/pylint/pylint/doc/whatsnew/2/2.15/index.rst
/home/runner/work/pylint/pylint/doc/whatsnew/2/2.15/index.rst:132: WARNING: duplicate label whatsnew/2/2.15/index:other bug fixes, other instance in /home/runner/work/pylint/pylint/doc/whatsnew/2/2.15/index.rst

@DudeNr33 do you have an opinion about the easy way to fix this ?

DanielNoord · 2022-09-01T19:50:41Z

We have titles that are duplicated when we generate the patch release note:

/home/runner/work/pylint/pylint/doc/whatsnew/2/2.15/index.rst:63: WARNING: duplicate label whatsnew/2/2.15/index:false positives fixed, other instance in /home/runner/work/pylint/pylint/doc/whatsnew/2/2.15/index.rst
/home/runner/work/pylint/pylint/doc/whatsnew/2/2.15/index.rst:132: WARNING: duplicate label whatsnew/2/2.15/index:other bug fixes, other instance in /home/runner/work/pylint/pylint/doc/whatsnew/2/2.15/index.rst

@DudeNr33 do you have an opinion about the easy way to fix this ?

Can we fix this by decreasing the title level? I haven't tested this, but can we have duplicate titles if they fall within different top level titles?

DudeNr33 · 2022-09-01T21:16:30Z

I'm currently on vacation and probably won't have time to try around myself until next Monday, sorry!
The underlines that are used by towncrier can be configured via the underlines option (see the readme).

I am a bit surprised that this is an issue, as I would expect others to experience this as well, but I did not find any issue about this in their issue tracker.
Is this maybe just because we include a :toctree:?
In this case decreasing the title level could work, but then again the toctree would be useless anyway and we could also just remove that instead of changing the title level.

…l is assigned to a class attribute inside the class where the function is defined. (pylint-dev#7395) Closes pylint-dev#6592

Previously pylint would lint a file passed on stdin even if the user meant to ignore the file. This commit fixes that issue. Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>

… annotations (pylint-dev#7400) Don't emit 'unused-variable' or 'unused-import' on names in string literal type annotations (pylint-dev#3299) Don't treat strings inside typing.Literal as names

…ylint-dev#7410)

)

Pierre-Sassoulas · 2022-09-06T20:28:20Z

I'm going to fix the release note manually to be able to release until we discuss what we should do. Not sure what to do with #7398, it's in 2.16.0 but it's labelled "need backport", what do you think @DanielNoord ?

DanielNoord · 2022-09-06T20:29:40Z

I thought it would be good to backport as there were other PRs that target that code.

If there are regression it would be helpful to have the refactor available on the maintenance branch as well.

* Fix and refactors for ``docparams`` extension The ``re_only_desc`` regex did not match for white and characters after ``\n``, so some description-only lines weren't getting matched. In addition, lookaheads were added to ``re_param_line`` (i.e. make sure the type group is not followed by a new line (``\n``)). Lastly, named groups (ala Perl regular expressions) were added for slightly improved clarity. Co-authored-by: Hendry, Adam <adam.grant.hendry@gmail.com>

Pierre-Sassoulas · 2022-09-06T21:10:22Z

Alright, I moved it to 2.15.1 and cherry-picked it :) I think we can release now

Saw some files

DanielNoord · 2022-09-06T21:15:53Z

btw, for future reviews I think we should split up the back port and release PRs. Stuff like the broken towncrier files are difficult to spot in larger PRs like this.

For now it is fine though! 😄

Pierre-Sassoulas · 2022-09-06T21:28:01Z

Forgot to regenerate the towncrier file after adding 3 more cherry-pick, my bad.

DanielNoord · 2022-09-06T21:40:57Z

+- Fix ignored files being linted when passed on stdin.
+
+  Closes #4354 (`#4354 <https://github.com/PyCQA/pylint/issues/4354>`_)
+- ``missing-return-doc``, ``missing-raises-doc`` and ``missing-yields-doc`` now respect


Doesn't towncrier know about white spaces? 😅

I manually removed the duplicated titles, which is why there might be some problems.

Let's fix in #7426

Rogdham and others added 2 commits September 1, 2022 12:15

Fix used-before-assignment for functions/classes defined in type ch…

be90099

…ecking guard Close pylint-dev#7368

Fix crash while iteraring over a class attribute (pylint-dev#7386)

9e2f535

Co-authored-by: orSolocate <38433858+orSolocate@users.noreply.github.com>

Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Sep 1, 2022

Pierre-Sassoulas added this to the 2.15.1 milestone Sep 1, 2022

Pierre-Sassoulas commented Sep 1, 2022

View reviewed changes

DanielNoord requested changes Sep 1, 2022

View reviewed changes

Pierre-Sassoulas mentioned this pull request Sep 2, 2022

Better release notes generation and automated release process #7362

Open

10 tasks

mbyrnepr2 and others added 8 commits September 6, 2022 22:15

Fix false positive for too-many-function-args when a function cal…

c4a770d

…l is assigned to a class attribute inside the class where the function is defined. (pylint-dev#7395) Closes pylint-dev#6592

Do not lint ignored file on stdin (pylint-dev#7220)

8a8de1f

Previously pylint would lint a file passed on stdin even if the user meant to ignore the file. This commit fixes that issue. Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>

Fix pylint-dev#3299 false positives with names in string literal type…

05404f0

… annotations (pylint-dev#7400) Don't emit 'unused-variable' or 'unused-import' on names in string literal type annotations (pylint-dev#3299) Don't treat strings inside typing.Literal as names

Make missing-return-doc respect the no-docstring-rgx option (p…

35007f5

…ylint-dev#7410)

Make disable-next only consider the succeeding line (pylint-dev#7411

939047e

)

Upgrade astroid version following 2.12.8 release

f2ecf4f

Make missing-yield/raises-doc respect no-docstring-rgx option

7848356

Suppress OSError in config file discovery (pylint-dev#7423)

bf1cbd6

Pierre-Sassoulas force-pushed the release-branch-2.15.1 branch from de3fd7f to 52d26bc Compare September 6, 2022 20:21

Fix 2.15 changelog (pylint-dev#7369)

62d0318

Pierre-Sassoulas force-pushed the release-branch-2.15.1 branch from 52d26bc to 3a8e9ee Compare September 6, 2022 20:28

Pierre-Sassoulas force-pushed the release-branch-2.15.1 branch from 3a8e9ee to 36f692d Compare September 6, 2022 21:09

Pierre-Sassoulas requested a review from DanielNoord September 6, 2022 21:10

DanielNoord previously approved these changes Sep 6, 2022

View reviewed changes

DanielNoord reviewed Sep 6, 2022

View reviewed changes

Comment thread doc/whatsnew/fragments/7368.false_positive Outdated

Bump pylint to 2.15.1, update changelog

f94c834

Pierre-Sassoulas force-pushed the release-branch-2.15.1 branch from 36f692d to f94c834 Compare September 6, 2022 21:26

Pierre-Sassoulas requested a review from DanielNoord September 6, 2022 21:27

Pierre-Sassoulas merged commit c5aefa2 into pylint-dev:maintenance/2.15.x Sep 6, 2022

Pierre-Sassoulas deleted the release-branch-2.15.1 branch September 6, 2022 21:34

DanielNoord reviewed Sep 6, 2022

View reviewed changes

Uh oh!

Conversation

Pierre-Sassoulas commented Sep 1, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DanielNoord left a comment

Choose a reason for hiding this comment

Uh oh!

Pierre-Sassoulas commented Sep 1, 2022

Uh oh!

Pierre-Sassoulas commented Sep 1, 2022

Uh oh!

DanielNoord commented Sep 1, 2022

Uh oh!

DudeNr33 commented Sep 1, 2022

Uh oh!

Pierre-Sassoulas commented Sep 6, 2022

Uh oh!

DanielNoord commented Sep 6, 2022

Uh oh!

Pierre-Sassoulas commented Sep 6, 2022

Uh oh!

Uh oh!

DanielNoord commented Sep 6, 2022

Uh oh!

Pierre-Sassoulas commented Sep 6, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants