Remove the python3 porting mode from the codebase#4942
Merged
Pierre-Sassoulas merged 1 commit intoSep 1, 2021
Merged
Conversation
Pierre-Sassoulas
added
the
Maintenance
Member
Author
|
@DanielNoord, I opened that following your suggestion in #4940 |
Collaborator
|
Looks good, quite a lot of work! I will rebase #4940 after this has been merged and see if there are any remaining issues. |
Collaborator
cdce8p
approved these changes
Aug 31, 2021
Member
cdce8p
left a comment
cdce8p
left a comment
There was a problem hiding this comment.
Looks good! As this is quite a large change, would you mind adding an entry in whatsnew?
2 tasks
Pull Request Test Coverage Report for Build 1189032117
💛 - Coveralls |
It's possible to use the python3 porting checker from an older pylint version. But it's not evolving anymore and was costing resource to maintain.
Pierre-Sassoulas
force-pushed
the
remove-python3-porting-checker
branch
from
26d5bb5 to
807bee4
Compare
Member
Author
|
Thank you for checking the issue we can close @DanielNoord :) |
Pierre-Sassoulas
added a commit
that referenced
this pull request
Feb 25, 2022
Pierre-Sassoulas
added a commit
that referenced
this pull request
Feb 26, 2022
Pierre-Sassoulas
added a commit
that referenced
this pull request
Feb 26, 2022
This was referenced Jun 10, 2022
joshfriend
pushed a commit
to MichiganLabs/python-config
that referenced
this pull request
Jun 13, 2022
timokoch
pushed a commit
to dumux/dumux
that referenced
this pull request
Jun 22, 2022
The py2/3 compatibility layer has been removed pylint-dev/pylint#4942
timokoch
pushed a commit
to dumux/dumux
that referenced
this pull request
Jun 22, 2022
The py2/3 compatibility layer has been removed pylint-dev/pylint#4942
iamsaywhat
added a commit
to emlid/code-quality
that referenced
this pull request
Jun 29, 2022
When using pylint v2.14, you can get a bunch of errors like: /action/lib/.automation/.python-lint:1:0: E0015: Unrecognized option found: no-space-check (unrecognized-option) /action/lib/.automation/.python-lint:1:0: R0022: Useless option value for '--disable', 'print-statement' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value) /action/lib/.automation/.python-lint:1:0: R0022: Useless option value for '--disable', 'parameter-unpacking' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value) /action/lib/.automation/.python-lint:1:0: R0022: Useless option value for '--disable', 'unpacking-in-except' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value) Most of them have beed removed here: pylint-dev/pylint#4942 But raising exceptions when using removed options was only added in 2.14 in pylint-dev/pylint#6826 We still need to actualize this config with new options, but at least we won't get errors with this config.
eliflores
added a commit
to eliflores/coding-katas-python
that referenced
this pull request
Jul 20, 2022
To fix: ``` ************* Module /Users/lalyta/dev/coding-katas-python/.pylintrc .pylintrc:1:0: R0022: Useless option value for '--disable', 'print-statement' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value) .pylintrc:1:0: R0022: Useless option value for '--disable', 'parameter-unpacking' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value) ... ```
eliflores
added a commit
to eliflores/coding-katas-python
that referenced
this pull request
Jul 20, 2022
To fix: ``` ************* Module /Users/lalyta/dev/coding-katas-python/.pylintrc .pylintrc:1:0: R0022: Useless option value for '--disable', 'print-statement' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value) .pylintrc:1:0: R0022: Useless option value for '--disable', 'parameter-unpacking' was removed from pylint, see pylint-dev/pylint#4942. (useless-option-value) ... ```
6 tasks
cameron-simpson
added a commit
to cameron-simpson/css
that referenced
this pull request
Nov 5, 2022
1 task
1 task
This was referenced Oct 9, 2023
4 tasks
This was referenced Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
It's possible to use the python3 porting checker from
an older pylint version. But it's not evolving anymore
and was costing resource to maintain.