You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You might have noticed the many warnings emitted when running pylint. These are due to PISA's current pylintrc file, the last changes to which were made nearly seven years ago. At the time, Pylint 2.2.2 was the most recent release, whereas Pylint 4.0.4 was released a couple of weeks ago. The file was originally generated in 83e2832, possibly with Pylint 1.7, and only underwent three minor changes.
As a result, we are
specifying options that aren't recognised any longer:
W0012: Unknown option value for '--enable', expected a valid pylint message and got 'old-octal-literal' (unknown-option-value)
W0012: Unknown option value for '--enable', expected a valid pylint message and got 'old-ne-operator' (unknown-option-value)
W0012: Unknown option value for '--enable', expected a valid pylint message and got 'long-suffix' (unknown-option-value)
The new pylintrc in this PR accounts for all the changes to Pylint's configuration options, and has been condensed down to a minimal version, containing only PISA's non-default option values. I produced it by generating a new file from the existing configuration with Pylint 4.0.4 (pylint --generate-rcfile > <filename>), a new file with defaults only (pylint --rcfile="" --generate-rcfile > <filename2>), and comparing the two.
I still need to check whether there are any recent equivalent settings that I need to specify to replace the old unrecognised ones. If this turns out to be too much of an effort, I'd suggest to just ignore them and live with the fact that we've lost certain non-default configuration options.
Also, I want to check which minimum Pylint version we should now require in setup.py
Below are the results of some quick research on the 14 unrecognised options. Their functionality does not seem to be implemented any longer and I doubt anyone here cares about them.
Concerning the minimum version, the last version below 3.0 does not recognise "use-implicit-booleaness-not-comparison-to-string" and "use-implicit-booleaness-not-comparison-to-zero" option values for the "disable" option. Versions >= 3.0 do not seem to be troubled by the new pylintrc. There is probably no harm in requiring the latest release version though, let's see.
Finally, concerning the three unknown option values (W0012) above, they all seem to have been relevant during a Python 2 -> 3 transition, so there's nothing to do with respect to those either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You might have noticed the many warnings emitted when running pylint. These are due to PISA's current pylintrc file, the last changes to which were made nearly seven years ago. At the time, Pylint 2.2.2 was the most recent release, whereas Pylint 4.0.4 was released a couple of weeks ago. The file was originally generated in 83e2832, possibly with Pylint 1.7, and only underwent three minor changes.
As a result, we are
The new pylintrc in this PR accounts for all the changes to Pylint's configuration options, and has been condensed down to a minimal version, containing only PISA's non-default option values. I produced it by generating a new file from the existing configuration with Pylint 4.0.4 (
pylint --generate-rcfile > <filename>), a new file with defaults only (pylint --rcfile="" --generate-rcfile > <filename2>), and comparing the two.