Skip to content

Conversation

@Pierre-Sassoulas
Copy link
Member

Description

This create a MessageId class with its unit tests, and permit some simplification in pylint.message. It rename MessageStore to MessageDefinitionStore because we anticipate to have a MessageIdStore later. It will permit other simplifications in the next step of this refactor, but let's keep the MR small.

Type of Changes

Type
🔨 Refactoring

Related Issue

Next step in order to make #2992 easier to review.

@Pierre-Sassoulas Pierre-Sassoulas force-pushed the create-a-pylint-message-id-class branch from a3cfd51 to edd7067 Compare August 6, 2019 17:48
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 89.993% when pulling edd7067 on Pierre-Sassoulas:create-a-pylint-message-id-class into 3b18105 on PyCQA:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 89.993% when pulling edd7067 on Pierre-Sassoulas:create-a-pylint-message-id-class into 3b18105 on PyCQA:master.

@coveralls
Copy link

coveralls commented Aug 6, 2019

Coverage Status

Coverage increased (+0.02%) to 89.993% when pulling edd7067 on Pierre-Sassoulas:create-a-pylint-message-id-class into 3b18105 on PyCQA:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 89.993% when pulling edd7067 on Pierre-Sassoulas:create-a-pylint-message-id-class into 3b18105 on PyCQA:master.

@Pierre-Sassoulas
Copy link
Member Author

Performance-wise this MessageId class was not a good idea. I'm removing it.

@Pierre-Sassoulas Pierre-Sassoulas deleted the create-a-pylint-message-id-class branch August 10, 2019 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants