[pylint.message] Use MessageId for old names

Author: Pierre-Sassoulas

pylint/message/message_definition.py

@@ -30,7 +30,12 @@ def __init__(
         self.scope = scope
         self.minversion = minversion
         self.maxversion = maxversion
-        self.old_names = old_names or []
+        self.old_names = []
+        if old_names:
+            for old_msgid, old_symbol in old_names:
+                MessageId.check_msgid(old_msgid)
+                old_message_id = MessageId(old_msgid, old_symbol)
+                self.old_names.append(old_message_id)
 
     @property
     def symbol(self):

pylint/message/message_definition_store.py

@@ -53,11 +53,13 @@ def register_message(self, message):
         self._check_symbol(message.msgid, message.symbol)
         self._check_msgid(message.msgid, message.symbol)
         for old_name in message.old_names:
-            self._check_symbol(message.msgid, old_name[1])
+            self._check_symbol(message.msgid, old_name.symbol)
         self._messages_definitions[message.symbol] = message
         self._register_alternative_name(message, message.msgid, message.symbol)
-        for old_id, old_symbol in message.old_names:
-            self._register_alternative_name(message, old_id, old_symbol)
+        for old_message_id in message.old_names:
+            self._register_alternative_name(
+                message, old_message_id.msgid, old_message_id.symbol
+            )
         self._msgs_by_category[message.msgid[0]].append(message.msgid)
 
     def _register_alternative_name(self, msg, msgid, symbol):
@@ -78,9 +80,9 @@ def _check_symbol(self, msgid, symbol):
             if alternative_message.symbol == symbol:
                 alternative_msgid = alternative_message.msgid
             else:
-                for old_msgid, old_symbol in alternative_message.old_names:
-                    if old_symbol == symbol:
-                        alternative_msgid = old_msgid
+                for old_message_id in alternative_message.old_names:
+                    if old_message_id.symbol == symbol:
+                        alternative_msgid = old_message_id.msgid
                         break
             if msgid != alternative_msgid:
                 self._raise_duplicate_msgid(symbol, msgid, alternative_msgid)
@@ -104,10 +106,10 @@ def _check_id_and_symbol_consistency(self, msgid, symbol):
             return None
         old_symbolic_name = None
         old_symbolic_id = None
-        for alternate_msgid, alternate_symbol in alternative.old_names:
-            if alternate_msgid == msgid or alternate_symbol == symbol:
-                old_symbolic_id = alternate_msgid
-                old_symbolic_name = alternate_symbol
+        for old_message_id in alternative.old_names:
+            if old_message_id.msgid == msgid or old_message_id.symbol == symbol:
+                old_symbolic_id = old_message_id.msgid
+                old_symbolic_name = old_message_id.symbol
         if symbol not in (alternative.symbol, old_symbolic_name):
             if msgid == old_symbolic_id:
                 self._raise_duplicate_symbol(msgid, symbol, old_symbolic_name)