Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RDTSC key because detection removed in SDL3 #2502

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Remove RDTSC key because detection removed in SDL3 #2502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion buildconfig/stubs/pygame/system.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ from typing_extensions import TypedDict
from pygame._data_classes import PowerState

class _InstructionSets(TypedDict):
RDTSC: bool
ALTIVEC: bool
MMX: bool
SSE: bool
Expand Down
4 changes: 3 additions & 1 deletion docs/reST/ref/system.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
::

{
'RDTSC': True,
'ALTIVEC': False,
'MMX': True,
'SSE': True,
Expand All @@ -52,6 +51,9 @@

.. versionadded:: 2.3.1

.. versionchanged:: 2.4.0 removed ``RDTSC`` key,
as it has been removed in pre-release SDL3

.. function:: get_total_ram

| :sl:`get the amount of RAM configured in the system`
Expand Down
2 changes: 1 addition & 1 deletion src_c/system.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ pg_system_get_cpu_instruction_sets(PyObject *self, PyObject *_null)
} \
Py_DECREF(tmp_bool);

INSERT_INSTRUCTIONSET_INFO("RDTSC", SDL_HasRDTSC);
// Don't insert SDL_HasRDTSC because it's been removed in SDL3
INSERT_INSTRUCTIONSET_INFO("ALTIVEC", SDL_HasAltiVec);
INSERT_INSTRUCTIONSET_INFO("MMX", SDL_HasMMX);
INSERT_INSTRUCTIONSET_INFO("SSE", SDL_HasSSE);
Expand Down
Loading