Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RDTSC key because detection removed in SDL3 #2502

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Remove RDTSC key because detection removed in SDL3 #2502

merged 1 commit into from
Oct 7, 2023

Conversation

Starbuck5
Copy link
Member

@Starbuck5 Starbuck5 commented Oct 6, 2023 •
edited
Loading

My rationale for straight up removing it is because I doubt anyone is using it.

I'm open to other suggestions of how to do the change management.

@Starbuck5 Starbuck5 added system pygame.system sdl3 labels Oct 6, 2023
@Starbuck5 Starbuck5 requested a review from a team as a code owner October 6, 2023 03:48
@Starbuck5 Starbuck5 requested a review from yunline October 6, 2023 03:48
ankith26
ankith26 approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I too think removing it entirely is the way to proceed, thanks 🎉

yunline
yunline approved these changes Oct 7, 2023
View reviewed changes
Copy link
Contributor

@yunline yunline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ankith26 ankith26 added this to the 2.4.0 milestone Oct 7, 2023
@ankith26 ankith26 merged commit 24f1726 into pygame-community:main Oct 7, 2023
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 approved these changes

@yunline yunline yunline approved these changes

Assignees
No one assigned
Labels
sdl3 system pygame.system
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Starbuck5 @yunline @ankith26