.resample now supports loffset. #2608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @dcherian! Thanks for submitting the PR.
|
…ture/loffset * 'feature/loffset' of github.com:dcherian/xarray: Update whats-new.rst
shoyer
reviewed
Dec 16, 2018
| dims=dim_coord.dims, name=RESAMPLE_DIM) | ||
| grouper = pd.Grouper(freq=freq, closed=closed, label=label, base=base) | ||
| grouper = pd.Grouper(freq=freq, closed=closed, label=label, base=base, | ||
| loffset=pd.tseries.frequencies.to_offset(loffset)) |
Member
There was a problem hiding this comment.
Do we need this explicit cast with pd.tseries.frequencies.to_offset? I guess it's safe to use since it's listed in the pandas API docs explicitly, but I get a little nervous about digging into internals in other projects.
Contributor
Author
There was a problem hiding this comment.
It's needed for pandas 0.19.2 which is our minimum version. on 0.23 pandas does the cast automatically.
dcherian
pushed a commit
to yohai/xarray
that referenced
this pull request
Dec 19, 2018
* master: .resample now supports loffset. (pydata#2608) Remove failing Appveyor Python 2.7 32-bit build (pydata#2617) Remove meaningless tz argument in cftime_range (pydata#2613) doc fixes. (pydata#2611) Fix parsing '_Unsigned' attribute (pydata#2584) fix a few typos in rst files (pydata#2607)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstfor all changes andapi.rstfor new API