Skip to content

Fix parsing '_Unsigned' attribute #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shoyer merged 6 commits into from
Dec 15, 2018
Merged

Fix parsing '_Unsigned' attribute #2584

shoyer merged 6 commits into from
Dec 15, 2018

Conversation

@dcherian
Copy link
Contributor

@dcherian dcherian commented Nov 30, 2018 •
edited
Loading

@pep8speaks
Copy link

pep8speaks commented Nov 30, 2018 •
edited
Loading

Hello @dcherian! Thanks for updating the PR.

Line 660:80: E501 line too long (82 > 79 characters)

Comment last updated on December 15, 2018 at 21:01 Hours UTC

@dcherian dcherian mentioned this pull request Nov 30, 2018
Closed
@dcherian dcherian changed the title Fix parsing '_Unsigned' attribute [WIP] Fix parsing '_Unsigned' attribute Nov 30, 2018
dcherian
dcherian commented Dec 14, 2018
View reviewed changes
@dcherian dcherian changed the title [WIP] Fix parsing '_Unsigned' attribute Fix parsing '_Unsigned' attribute Dec 15, 2018
@dcherian
Copy link
Contributor Author

dcherian commented Dec 15, 2018

Looks like the scipy import failed on appveyor somehow.

@shoyer shoyer merged commit f8cced7 into pydata:master Dec 15, 2018
@shoyer
Copy link
Member

shoyer commented Dec 15, 2018

I'm not worried about the appveyor failure. Thanks @dcherian!

dcherian pushed a commit to yohai/xarray that referenced this pull request Dec 19, 2018
Merge branch 'master' into yohai-ds_scatter
84d4cbc 
* master:
  .resample now supports loffset. (pydata#2608)
  Remove failing Appveyor Python 2.7 32-bit build (pydata#2617)
  Remove meaningless tz argument in cftime_range (pydata#2613)
  doc fixes. (pydata#2611)
  Fix parsing '_Unsigned' attribute (pydata#2584)
  fix a few typos in rst files (pydata#2607)
@dcherian dcherian deleted the fix/unsigned branch April 12, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shoyer shoyer shoyer left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

decode_cf not scaling and off-setting correctly

3 participants

@dcherian @pep8speaks @shoyer