ROB: fix extract_text() issues on damaged PDFs #2760
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2760 +/- ##
==========================================
+ Coverage 95.84% 95.85% +0.01%
==========================================
Files 51 51
Lines 8523 8522 -1
Branches 1692 1691 -1
==========================================
Hits 8169 8169
Misses 209 209
+ Partials 145 144 -1 ☔ View full report in Codecov by Sentry. |
|
Is there something we can do about the coverage here? |
|
The modification is properly test covered. The incomplete coverage is on the original condition but I do not see what is wrong. any ideas ? |
|
@stefan6419846 ,? |
|
I recommend to remove the pragma in this case. It seems like we somehow end up with incomplete branch coverage, but it is not clear to me why. I will be merging this without the pragma in this case. |
closes py-pdf#2726 superseed proposal py-pdf#2791
|
Seems like there are some more changes required after the merge of main, as there are still references to the removed |
|
I 'm definitively not fond of the conflict managment through the web pages. |
## Version 5.0.0, 2024-09-15 This version drops support for Python 3.7 (not maintained since July 2023), PdfMerger (use PdfWriter instead) and AnnotationBuilder (use annotations instead). ### Deprecations (DEP) - Remove the deprecated PfdMerger and AnnotationBuilder classes and other deprecations cleanup (#2813) - Drop Python 3.7 support (#2793) ### New Features (ENH) - Add capability to remove /Info from PDF (#2820) - Add incremental capability to PdfWriter (#2811) - Add UniGB-UTF16 encodings (#2819) - Accept utf strings for metadata (#2802) - Report PdfReadError instead of RecursionError (#2800) - Compress PDF files merging identical objects (#2795) ### Bug Fixes (BUG) - Fix sheared image (#2801) ### Robustness (ROB) - Robustify .set_data() (#2821) - Raise PdfReadError when missing /Root in trailer (#2808) - Fix extract_text() issues on damaged PDFs (#2760) - Handle images with empty data when processing an image from bytes (#2786) ### Developer Experience (DEV) - Fix coverage uploads (#2832) - Test against Python 3.13 (#2776) [Full Changelog](4.3.1...5.0.0)
closes #2702