-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STY: Rename b_ to bytes_ #2791
STY: Rename b_ to bytes_ #2791
Conversation
More self-documenting and consistent with str_.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2791 +/- ##
=======================================
Coverage 95.16% 95.16%
=======================================
Files 51 51
Lines 8545 8545
Branches 1703 1703
=======================================
Hits 8132 8132
Misses 261 261
Partials 152 152 ☔ View full report in Codecov by Sentry. |
tests/test_utils.py
Outdated
@@ -122,7 +122,7 @@ def test_mark_location(): | |||
], | |||
) | |||
def test_b(input_str: str, expected: bytes): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update the test name as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call.
please standby on b_ : I would like first to finish my analysis. This may introduce some slight performance improvements |
More self-documenting and consistent with str_.
closes py-pdf#2726 superseed proposal py-pdf#2791
More self-documenting and consistent with str_.